8000 [3.8] gh-115349: Pin theme to fix code snippets (GH-115351) by ambv · Pull Request #115404 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351) #115404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351) #115404

merged 1 commit into from
Feb 13, 2024

Conversation

ambv
Copy link
Contributor
@ambv ambv commented Feb 13, 2024 •
edited by bedevere-app bot
Loading

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

@hugovk @ambv
[3.8] [3.9] pythongh-115349: Pin theme to fix code snippets (pythonGH…
daf72c8 
…-115351)

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this pull request Feb 13, 2024
Merged
@bedevere-app bedevere-app bot mentioned this pull request Feb 13, 2024
Closed
hugovk
hugovk approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally:

image

@ambv
Copy link
Contributor Author
ambv commented Feb 13, 2024

@hugovk I appreciate it but this was about the dark theme, no?

@hugovk
Copy link
Member
hugovk commented Feb 13, 2024

Yes, we're pinning to the last version before the dark theme was added.

This the minimal fix, because the dark theme requires Sphinx 3 for proper syntax highlighting, and the 3.8/3.9 docs use Sphinx 2.4.4.

We can look into bumping Sphinx to 3+, but it will likely also require bumping other dependencies, and for security branches I felt it would be easier/safer to pin to an older python-docs-theme.

@ambv
Copy link
Contributor Author
ambv commented Feb 13, 2024

Ah, got it. Right. Okay then, let's go.

@ambv ambv merged commit a21c0c7 into python:3.8 Feb 13, 2024
@ambv ambv deleted the backport-3fcea41-3.8 branch February 13, 2024 13:44
@hugovk hugovk mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambv @hugovk
0