-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
[3.8] gh-115349: Pin theme to fix code snippets (GH-115351) #115404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk I appreciate it but this was about the dark theme, no? |
Yes, we're pinning to the last version before the dark theme was added. This the minimal fix, because the dark theme requires Sphinx 3 for proper syntax highlighting, and the 3.8/3.9 docs use Sphinx 2.4.4. We can look into bumping Sphinx to 3+, but it will likely also require bumping other dependencies, and for security branches I felt it would be easier/safer to pin to an older python-docs-theme. |
Ah, got it. Right. Okay then, let's go. |
Pin theme to fix code snippets
(cherry picked from commit 3fcea41)