[3.12] gh-112919: Speed-up datetime, date and time.replace() (GH-112921) #115344

eltoder · 2024-02-12T15:06:59Z

Use argument clinic and call new_* functions directly. This speeds up
these functions 6x to 7.5x when calling with keyword arguments.
(cherry picked from commit 1f515e8)

Co-authored-by: Eugene Toder eltoder@users.noreply.github.com

Issue: datetime.replace() is very slow #112919

…-112921) Use argument clinic and call new_* functions directly. This speeds up these functions 6x to 7.5x when calling with keyword arguments. (cherry picked from commit 1f515e8)

…ythonGH-112921) Use argument clinic and call new_* functions directly. This speeds up these functions 6x to 7.5x when calling with keyword arguments. (cherry picked from commit 1f515e8) Co-authored-by: Eugene Toder <eltoder@users.noreply.github.com>

eltoder · 2024-02-13T16:53:56Z

Hi @Yhg1s,

This PR is a backport from main. It's a simple change that gives a nice speedup, but the main goal is to make the backport of the bug-fix #114780 easier. If we backport this, the change for #114780 should apply cleanly without manual edits. This PR fails the ABI change check in CI, but it seems to be a false positive. (It just adds a few string constants.) @ericsnowcurrently says that this is OK to do in bugfix releases, but the decision is up to you.

Please let me know if we can backport this change or if I should write a separate version of #114780 for 3.12.

Thank you.

hugovk · 2024-08-12T08:27:42Z

"Check if the ABI has changed" is failing on the CI:

1 Changed variable:

  [C] '_PyRuntimeState _PyRuntime' was changed at pycore_runtime.h:192:1:
    size of symbol changed from 459992 to 460384

Generated ABI file is not up to date.
Please add the release manager of this branch as a reviewer of this PR.

The up to date ABI file should be attached to this build as an artifact.

To learn more about this check: https://devguide.python.org/setup/#regenerate-the-abi-dump

Error: Process completed with exit code 1.

terryjreedy · 2025-02-24T02:15:38Z

@hugovk I am curious what is pending? The generated file has 7 conflicts like


<<<<<<< backport-1f515e8-3.12
    _PyUnicode_InternInPlace(interp, &string);
    string = &_Py_ID(day);
    assert(_PyUnicode_CheckConsistency(string, 1));
    _PyUnicode_InternInPlace(interp, &string);
=======
    assert(PyUnicode_GET_LENGTH(string) != 1);
>>>>>>> 3.12

These seem easy enough to fix (keep backport?) and I could do that, but I assumed that generated files are not checked in.

hugovk · 2025-02-24T05:21:51Z

Most generated files are not checked in, but a handful are.

Several things pending:

@Yhg1s to decide whether this can be backported to 3.12
Merge conflict needs fixing
Generated ABI file needs updating

ambv · 2025-04-08T10:34:36Z

3.12 is entering security-only fixes mode today. Seems to me like this performance fix shouldn't go to 3.12 anyway.

eltoder and others added 2 commits February 10, 2024 01:35

pythongh-112919: Speed-up datetime, date and time.replace() (pythonGH…

20f3033

…-112921) Use argument clinic and call new_* functions directly. This speeds up these functions 6x to 7.5x when calling with keyword arguments. (cherry picked from commit 1f515e8)

eltoder requested review from pganssle and abalkin as code owners February 12, 2024 15:06

bedevere-app bot added the awaiting review label Feb 12, 2024

This was referenced Feb 12, 2024

gh-112919: Speed-up datetime, date and time.replace() #112921

Merged

datetime.replace() is very slow #112919

Closed

eltoder mentioned this pull request Feb 12, 2024

gh-89039: call subclass constructors in datetime.*.replace #114780

Merged

Merge branch '3.12' into backport-1f515e8-3.12

a3c79e5

hugovk added the pending The issue will be closed if no feedback is provided label Feb 17, 2025

ambv closed this Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.12] gh-112919: Speed-up datetime, date and time.replace() (GH-112921) #115344

[3.12] gh-112919: Speed-up datetime, date and time.replace() (GH-112921) #115344

[3.12] gh-112919: Speed-up datetime, date and time.replace() (GH-112921) #115344

[3.12] gh-112919: Speed-up datetime, date and time.replace() (GH-112921) #115344

Conversation