-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-35566: Add links to annotation glossary term #11291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term annotation in pickletools used in a generic sense rather than the type-annotation sense, so the link is not applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term annotation in pickletools used in a generic sense rather than the type-annotation sense, so the link is not applicable.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again Thank you for pointing that out. I wasn't sure of the usage in pickletools, but I guess I should have realized it wasn't related since the parm was added in 3.2, but typing in 3.5. |
Thanks for making the requested changes! @rhettinger: please review the changes made to this pull request. |
Thanks @csabella for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
(cherry picked from commit b7105c9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
GH-11302 is a backport of this pull request to the 3.7 branch. |
https://bugs.python.org/issue35566