gh-111347: Remove wrong assertion in test_sendfile #111377
Conversation
|
From you bug report I understand that the tell() value is only unreliable with ProactorEventLoop. Maybe you can detect that combo and skip it? |
Let me have a try. |
There was a problem hiding this comment.
I just had a thought. I'd like @zooba to think about this briefly -- maybe the Proactor code should arrange for the file position to be correctly updated after calling transmitFile?
I think it is a little bit difficult. Based on my experiment:
|
|
Okay, then let’s merge this! |
|
Thanks @zcxsythenew for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-111461 is a backport of this pull request to the 3.12 branch. |
|
GH-111462 is a backport of this pull request to the 3.11 branch. |
Windows is different.
Windows is different.
Windows is different.
Closes gh-111347.