8000 GH-111293: Fix DirEntry.inode dropping higher bits by zcxsythenew · Pull Request #111294 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-111293: Fix DirEntry.inode dropping higher bits #111294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2023
Merged

GH-111293: Fix DirEntry.inode dropping higher bits #111294

merged 3 commits into from
Oct 26, 2023

Conversation

zcxsythenew
Copy link
Contributor

GH-111293: Fix DirEntry.inode dropping higher bits

See #111293 for more details.

@ghost
Copy link
ghost commented Oct 25, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Closed
@bedevere-app
Copy link
bedevere-app bot commented Oct 25, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

zooba
zooba reviewed Oct 25, 2023
View reviewed changes
Copy link
Member
@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, just a couple of minor touch ups.

@zcxsythenew zcxsythenew requested a review from zooba October 26, 2023 01:46
@zooba zooba added the needs backport to 3.12 only security fixes label Oct 26, 2023
@zooba zooba merged commit b468538 into python:main Oct 26, 2023
@miss-islington-app
Copy link

Thanks @zcxsythenew for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2023
@zcxsythenew @miss-islington
pythonGH-111293: Fix DirEntry.inode dropping higher bits on Windows (p…
e719a7d 
…ythonGH-111294)

(cherry picked from commit b468538)

Co-authored-by: zcxsythenew <30565051+zcxsythenew@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Oct 26, 2023

GH-111367 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 26, 2023
zooba pushed a commit that referenced this pull request Oct 26, 2023
@miss-islington @zcxsythenew
GH-111293: Fix DirEntry.inode dropping higher bits on Windows (GH-111294
e25d8b4 
)

(cherry picked from commit b468538)

Co-authored-by: zcxsythenew <30565051+zcxsythenew@users.noreply.github.com>
@zcxsythenew zcxsythenew deleted the fix-issue-111293 branch October 26, 2023 22:21
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@zcxsythenew @aisk
pythonGH-111293: Fix DirEntry.inode dropping higher bits on Windows (p…
74ddbda 
…ythonGH-111294)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@zcxsythenew @Glyphack
pythonGH-111293: Fix DirEntry.inode dropping higher bits on Windows (p…
6199c63 
…ythonGH-111294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcxsythenew @zooba
0