gh-110572: Remove test_* from _testcapi/getargs.c
#111214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done! I've manually checked that >>> import _testcapi
>>> [(name, getattr(_testcapi, name))
... for name in dir(_testcapi)
... if name.startswith('test_') and name.endswith('_code')]
[]is empty. |
serhiy-storchaka
approved these changes
Oct 24, 2023
|
Thanks Nikita. It would be nice to backport the part of it to 3.12. Only add new functions, without removing old functions. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed, all these test now have modern alternatives.
I've also updated
test_empty_argparseto check more arguments. Now, there are notest_prefixed functions left ingetargs.ctest_*_codefunctions in_testcapi/getargs.chave memory leaks #110572