8000 gh-89902: Deprecate non-standard format specifier "N" for Decimal by serhiy-storchaka · Pull Request #110508 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-89902: Deprecate non-standard format specifier "N" for Decimal #110508

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

gh-89902: Deprecate non-standard format specifier "N" for Decimal #110508

merged 1 commit into from
Oct 8, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Oct 7, 2023 •
edited by github-actions bot
Loading

It was not documented and only supported in the C implementation.

📚 Documentation preview 📚: https://cpython-previews--110508.org.readthedocs.build/

@serhiy-storchaka
pythongh-89902: Deprecate non-standard format specifier "N" for Decimal 8000
be0074f 
It was not documented and only supported in the C implementation.
@bedevere-app bedevere-app bot mentioned this pull request Oct 7, 2023
Closed
mdickinson
mdickinson approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member
@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and I agree with the change.

@rhettinger rhettinger removed their request for review October 7, 2023 23:35
mdickinson
mdickinson approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member
@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying again: LGTM

(Something funny is going on with our automation here. Why is this labelled as "awaiting core review"?)

@serhiy-storchaka
Copy link
Member Author

Ignore it. The bot is broken for months already.

Thank you for your review.

@serhiy-storchaka serhiy-storchaka merged commit d96a8cd into python:main Oct 8, 2023
@serhiy-storchaka serhiy-storchaka deleted the deprecate-decimal-format-N branch October 8, 2023 07:01
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang 3.x has failed when building commit d96a8cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/4770) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/4770

Failed tests:

  • test_subprocess

Failed subtests:

  • test_pipesize_default - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesizes
  • test_pipesize_default - test.test_subprocess.ProcessTestCase.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCase.test_pipesizes

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line 769, in test_pipesize_default
    self.assertEqual(
AssertionError: 65536 != 8192


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line 727, in test_pipesizes
    p = subprocess.Popen(
        ^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line 992, in __init__
    errread, errwrite) = self._get_handles(stdin, stdout, stderr)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line 1731, in _get_handles
    fcntl.fcntl(errwrite, fcntl.F_SETPIPE_SZ, self.pipesize)
PermissionError: [Errno 1] Operation not permitted

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.x has failed when building commit d96a8cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/524/builds/4666) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/524/builds/4666

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_os.py", line 4085, in test_timerfd_select
    self.assertGreater(t, total_time)
AssertionError: 0.49994910099485423 not greater than 0.5

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x has failed when building commit d96a8cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/338/builds/5284) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/338/builds/5284

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIME
    self.assertGreater(t, offset)
AssertionError: 0.9999961559951771 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit d96a8cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/6083) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/6083

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME
  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line 4211, in test_timerfd_ns_TFD_TIMER_ABSTIME
    self.assertGreater(t, off
8000
set_ns)
AssertionError: 999973587 not greater than 1000000000


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIME
    self.assertGreater(t, offset)
AssertionError: 0.9999069161713123 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable Clang 3.x has failed when building commit d96a8cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/435/builds/3713) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/435/builds/3713

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang/build/Lib/test/test_os.py", line 4211, in test_timerfd_ns_TFD_TIMER_ABSTIME
    self.assertGreater(t, offset_ns)
AssertionError: 999993323 not greater than 1000000000

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-89902: Deprecate non-standard format specifier "N" for Decim…
a99440f 
…al (pythonGH-110508)

It was not documented and only supported in the C implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @bedevere-bot @mdickinson
0