10000 gh-110093: Replace trivial Py_BuildValue() with direct C API call by serhiy-storchaka · Pull Request #110094 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-110093: Replace trivial Py_BuildValue() with direct C API call #110094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2023
Merged

gh-110093: Replace trivial Py_BuildValue() with direct C API call #110094

merged 2 commits into from
Oct 20, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Sep 29, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2023
Closed
@skirpichev
Copy link
Contributor

Grep shows yet two instances in _decimal.c:

Modules/_datetimemodule.c:4050:    return Py_BuildValue("(OO)", self->offset, self->name);
Modules/_decimal/_decimal.c:4336:    ret = Py_BuildValue("(OO)", q, r);
Modules/_decimal/_decimal.c:5361:    ret = Py_BuildValue("(OO)", q, r);

Sorry for a nitpick if this was skipped intentionally.

@serhiy-storchaka
Copy link
Member Author

I know. I changed this code and reverted changes several time because I was unsure. This module is large and complex, and the code resisted changes in the past, so it is better to avoid changing it without great need.

@serhiy-storchaka serhiy-storchaka merged commit 59ea0f5 into python:main Oct 20, 2023
@serhiy-storchaka serhiy-storchaka deleted the replace-Py_BuildValue branch October 20, 2023 15:08
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit 59ea0f5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/315) and take a look at the build logs.
  4. Check if the failure is related to this commit (59ea0f5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1232/builds/315

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 18, done.        
remote: Counting objects:   5% (1/17)        
remote: Counting objects:  11% (2/17)        
remote: Counting objects:  17% (3/17)        
remote: Counting objects:  23% (4/17)        
remote: Counting objects:  29% (5/17)        
remote: Counting objects:  35% (6/17)        
remote: Counting objects:  41% (7/17)        
remote: Counting objects:  47% (8/17)        
remote: Counting objects:  52% (9/17)        
remote: Counting objects:  58% (10/17)        
remote: Counting objects:  64% (11/17)        
remote: Counting objects:  70% (12/17)        
remote: Counting objects:  76% (13/17)        
remote: Counting objects:  82% (14/17)        
remote: Counting objects:  88% (15/17)        
remote: Counting objects:  94% (16/17)        
remote: Counting objects: 100% (17/17)        
remote: Counting objects: 100% (17/17), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 18 (delta 5), reused 10 (delta 5), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '59ea0f523e155ac1a471cd292b41a76241fccd36'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 59ea0f523e gh-110093: Replace trivial Py_BuildValue() with direct C API call (GH-110094)
Switched to and reset branch 'main'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

1 error

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-110093: Replace trivial Py_BuildValue() with direct C API ca…
ab3fe5f 
…ll (pythonGH-110094)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-110093: Replace trivial Py_BuildValue() with direct C API ca…
2b9155a 
…ll (pythonGH-110094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @skirpichev @bedevere-bot
0