8000 gh-106919: Use role :c:macro: for referencing the C "constants" by serhiy-storchaka · Pull Request #106920 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-106919: Use role 8000 :c:macro: for referencing the C "constants" #106920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2023
Merged

gh-106919: Use role :c:macro: for referencing the C "constants" #106920

merged 4 commits into from
Jul 21, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jul 20, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Closed
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 20, 2023
erlend-aasland
erlend-aasland reviewed Jul 20, 2023
View reviewed changes
serhiy-storchaka and others added 2 commits July 20, 2023 21:36
@serhiy-storchaka @erlend-aasland
Apply suggestions from code review
d41eba4 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@serhiy-storchaka
Use explicit label names in references.
c16e6e4
erlend-aasland
erlend-aasland reviewed Jul 20, 2023
View reviewed changes
Doc/c-api/arg.rst
@@ -343,7 +343,7 @@ Other objects
*items*. Format units for sequences may be nested.

It is possible to pass "long" integers (integers whose value exceeds the
platform's :const:`LONG_MAX`) however no proper range checking is done --- the
platform's :c:macro:`LONG_MAX`) however no proper range checking is done --- the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platform's :c:macro:`LONG_MAX`) however no proper range checking is done --- the
platform's :c:macro:`!LONG_MAX`) however no proper range checking is done --- the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it may be better to solve this for standard C names globally.

erlend-aasland
erlend-aasland approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit. Thanks!

ezio-melotti
ezio-melotti approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serhiy-storchaka @ezio-melotti
Update Doc/c-api/structures.rst
81b5927 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit fcc816d into python:main Jul 21, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-c-macro-roles branch July 21, 2023 07:52
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fcc816dbff7ca66c26f57a506e4d2330fe41d0ff 3.12

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker fcc816dbff7ca66c26f57a506e4d2330fe41d0ff 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] pythongh-106919: Use role :c:macro: for referencing the C "con…
ae8937a 
…stants" (pythonGH-106920).

(cherry picked from commit fcc816d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106951 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.11] pythongh-106919: Use role :c:macro: for referencing the C "con…
039e3fc 
…stants" (pythonGH-106920).

(cherry picked from commit fcc816d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106952 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] gh-106919: Use role :c:macro: for referencing the C "constants" (
ac9aa8a 
GH-106920) (GH-106951)

(cherry picked from commit fcc816d)
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
9BE5
@serhiy-storchaka
[3.11] gh-106919: Use role :c:macro: for referencing the C "constants" (
6bde1b9 
GH-106920) (GH-106952)

(cherry picked from commit fcc816d)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @erlend-aasland @ezio-melotti
0