8000 gh-84436 Add integration C API tests for immortal objects by corona10 · Pull Request #103962 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
< 8000 h1 class="gh-header-title mb-2 lh-condensed f1 mr-0 flex-auto wb-break-word"> gh-84436 Add integration C API tests for immortal objects #103962
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 2, 2023
Merged

gh-84436 Add integration C API tests for immortal objects #103962

merged 14 commits into from
May 2, 2023

Conversation

corona10
Copy link
Member
@corona10 corona10 commented Apr 28, 2023 •
edited by bedevere-bot
Loading

Got motivation from #103922 (comment)
This PR is not the answer to the need for emulation mode but for minimum verification.

@corona10 corona10 requested a review from a team as a code owner April 28, 2023 02:13
@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2023
Closed
corona10
corona10 commented Apr 28, 2023
View reviewed changes
erlend-aasland
erlend-aasland reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look on my phone. I'll take a better look later today.

@corona10 corona10 requested a review from erlend-aasland April 28, 2023 05:48
erlend-aasland
erlend-aasland reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments on test_immortal_bool. The same comments applies to the rest of the test functions.

@corona10 corona10 requested a review from erlend-aasland April 28, 2023 11:26
@JelleZijlstra JelleZijlstra changed the title gh-84436 Add intergration C API tests for immortal objects gh-84436 Add integration C API tests for immortal objects Apr 29, 2023
@corona10
Copy link
Member Author

@erlend-aasland @JelleZijlstra @iritkatriel
If there is no major objection, I prefer to merge this PR by next week.
I expect that if the more immortal type is added, more test cases will be added here.

@corona10 corona10 force-pushed the gh-84436-objects branch from 5b3447a to a3df017 Compare May 2, 2023 03:38
erlend-aasland
erlend-aasland reviewed May 2, 2023
View reviewed changes
@corona10 corona10 force-pushed the gh-84436-objects branch from a3df017 to e0295b5 Compare May 2, 2023 10:14
@corona10 corona10 requested a review from erlend-aasland May 2, 2023 10:22
@corona10
Copy link
Member Author
corona10 commented May 2, 2023 •
edited
Loading

Merge this PR. If there needs some improvement, please let me know!

@corona10 corona10 merged commit d81ca7e into python:main May 2, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
@carljm
Merge branch 'main' into inlinecomp2
0727d6f 
* main:
  pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)
  pythongh-65022: Fix description of tuple return value in copyreg (python#103892)
  pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)
  pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)
  pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)
  pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)
  pythonGH-103484: Fix redirected permanently URLs (python#104001)
  Improve assert_type phrasing (python#104081)
  pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)
  pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)
  pythongh-88496: IDLE - fix another test on macOS (python#104075)
  pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)
  pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)
  pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
@corona10 corona10 deleted the gh-84436-objects branch May 2, 2023 21:59
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
@carljm
Merge branch 'main' into cached_property_docs
b9c39e3 
* main: (760 commits)
  pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103)
  pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105)
  pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)
  pythongh-65022: Fix description of tuple return value in copyreg (python#103892)
  pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)
  pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)
  pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)
  pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)
  pythonGH-103484: Fix redirected permanently URLs (python#104001)
  Improve assert_type phrasing (python#104081)
  pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)
  pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)
  pythongh-88496: IDLE - fix another test on macOS (python#104075)
  pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)
  pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)
  pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @erlend-aasland @bedevere-bot
0