gh-102941: Fix "‘subobj’ may be used uninitialized in this function" warning in bytes_methods.c
#102942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion" warning in `bytes_methods.c`
|
The warning is gone 🎉 @kumaraditya303 can you please take a look? :) |
|
@erlend-aasland can you please take a look? :) |
|
I'm travelling currently, please find another reviewer or wait till I'm back. |
JelleZijlstra
approved these changes
Mar 27, 2023
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
…tion" warning in `bytes_methods.c` (python#102942)
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…tion" warning in `bytes_methods.c` (python#102942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still think that this warning is a false positive and there's no way to actually abuse it.
So, I hope that
= NULLwill just make it go away.Objects/bytes_methods.c#102941