gh-102615: Fix type vars substitution of collections.abc.Callable and custom generics with ParamSpec
#102681
Conversation
…ble` and custom generics with `ParamSpec`
|
I encountered another bug, the EDIT: THIS MIGHT NOT BE A BUG, AS ITS AN INVALID USE. PLEASE IGNORE THIS @sobolevn |
|
@Fidget-Spinner I would like to move all I've only touched params substitution here. |
|
Wait a moment, this is not about >>> ca.Callable[[int, P], int][P].__args__
(<class 'int'>, ~P, <class 'int'>)
>>> ca.Callable[[int, P], int][P][int].__args__
(<class 'int'>, (<class 'int'>,), <class 'int'>) |
|
Funny thing, I just removed this code from if (len(self.__parameters__) == 1
and _is_param_expr(self.__parameters__[0])
and item and not _is_param_expr(item[0])):
item = (item,)All tests still pass :) 🤯 |
There was a problem hiding this comment.
I think the runtime is correct in raising TypeError for these situations, actually: see #102615 (comment)
Maybe instead, we should focus on improving the error message, so that users get more specific feedback on why the substitution is being disallowed? Though if it adds too much complexity to the code, I probably wouldn't bother with it.
|
I am going to close this for now, I will add new tests in other PRs, because this one has a big unrelated history. |
I would prefer to create two PRs to fix #102615
Callableand custom generics withParamSpeclistinstead oftupleinreprof paramspec #102637 to change therepr