10000 Update macOS installer builds to use ncurses 6.5 · Issue #91132 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Update macOS installer builds to use ncurses 6.5 #91132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ned-deily opened this issue Mar 10, 2022 · 9 comments
Closed

Update macOS installer builds to use ncurses 6.5 #91132

ned-deily opened this issue Mar 10, 2022 · 9 comments
Assignees
@ned-deily
Labels
3.12 only security fixes 3.13 bugs and security fixes build The build process and cross-build OS-mac type-security A security issue

Comments

@ned-deily
Copy link
Member
ned-deily commented Mar 10, 2022 •
edited by bedevere-app bot
Loading
BPO 46976
Nosy @ronaldoussoren, @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = None
created_at = <Date 2022-03-10.17:07:20.172>
labels = ['OS-mac', '3.9', '3.10', '3.11']
title = 'Update macOS installer builds to use ncurses 6.3'
updated_at = <Date 2022-03-10.17:53:11.656>
user = 'https://github.com/ned-deily'

bugs.python.org fields:

activity = <Date 2022-03-10.17:53:11.656>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = False
closed_date = None
closer = None
components = ['macOS']
creation = <Date 2022-03-10.17:07:20.172>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 46976
keywords = []
message_count = 2.0
messages = ['414869', '414874']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'ned.deily']
pr_nums = []
priority = 'high'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue46976'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

Linked PRs
@ned-deily
Copy link
Member Author

The python.org macOS installers include a private copy of the ncurses library; it has not been updated from 5.9 in a long time. The current upstream version is 6.3 and includes bug and security fixes; we should update to it.

@ned-deily ned-deily added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes OS-mac labels Mar 10, 2022
@ned-deily
Copy link
Member Author

Assigning to myself as this will require some installer build testing.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@erlend-aasland erlend-aasland added the build The build process and cross-build label May 20, 2022
@erlend-aasland erlend-aasland moved this to Build in Curses issues May 20, 2022
@gpshead gpshead added 3.12 only security fixes and removed 3.9 only security fixes labels Nov 2, 2022
@vstinner
Copy link
Member
vstinner commented Nov 2, 2022

The python.org macOS installers include a private copy of the ncurses library; it has not been updated from 5.9 in a long time. The current upstream version is 6.3 and 8000 includes bug and security fixes; we should update to it.

$ grep ncurses Mac/BuildScript/build-installer.py
              url="http://ftp.gnu.org/pub/gnu/ncurses/ncurses-5.9.tar.gz",
                  ("ftp://ftp.invisible-island.net/ncurses//5.9/ncurses-5.9-20120616-patch.sh.bz2",

Ah right, ncurses 5.9 is still used. This version has multiple 3 known security vulnerabilities:

ncurses-5.9-20120616-patch.sh.bz2 is a shell script updating ncurses to 5.9 (20120616).

# Use this script to patch ncurses 5.9 to 5.9 (20120616)
# Run this script inside the ncurses 5.9 source directory et voila! Updated.

@ned-deily
Copy link
Member Author

Sorry, I had planned to do an update prior to the 3.11.0 release but it didn't get done. I will get to it shortly.

@gpshead gpshead added the type-security A security issue label Nov 3, 2022
@erlend-aasland erlend-aasland added 3.13 bugs and security fixes and removed 3.10 only security fixes labels Feb 8, 2024
@erlend-aasland
Copy link
Contributor

Should we try to get this done for 3.13? Is there anything I can help with? Is the "installer build testing" documented somewhere (I did not find much in the READMEs)?

@ronaldoussoren
Copy link
Contributor

FWIW, I have some code locally that installs n 8000 curses 6.4 + patches for when I work on Python. That build passes the entire test suite with this invocation of configure:

    subprocess.check_call(
        [   
            "./configure",
            "--enable-widec",
            "--without-cxx",
            "--without-cxx-binding",
            "--without-ada",
            "--without-curses-h",
            "--enable-shared",
            "--with-shared",
            "--without-debug",
            "--without-normal",
            "--without-tests",
            "--without-manpages",
            "--without-gpm",
            "--datadir=/usr/share",
            "--sysconfdir=/etc",
            "--sharedstatedir=/usr/com",
            "--with-terminfo-dirs=/usr/share/terminfo",
            "--with-default-terminfo-dir=/usr/share/terminfo",
            "--enable-pc-files",
            f"--prefix={PREFIX}",
            f"CFLAGS=-mmacosx-version-min={DEPLOYMENT_TARGET} -arch arm64 -arch x86_64 -Werror=unguarded-availability-new -g",
            f"LDFLAGS=-mmacosx-version-min={DEPLOYMENT_TARGET} -arch arm64 -arch x86_64 -g",
        ],
        cwd=src_path,
        stdout=subprocess.DEVNULL,
    )

I did have to do some tweaking of a makefile to avoid trying to install termini files in a system location, but that's a trivial change as well.

@ned-deily
Copy link
Member Author

Thanks, I will try that soon.

@cmang cmang mentioned this issue Feb 8, 2024
Open
@cmang
Copy link
cmang commented Feb 9, 2024 •
edited
Loading

The python.org macOS installers include a private copy of the ncurses library; it has not been updated from 5.9 in a long time. The current upstream version is 6.3 and includes bug and security fixes; we should update to it.

Hi. I'm sorry to butt in on y'alls issue, but would this update mean that Python for macOS would switch from using the Ncurses 5 ABI to the Ncurses 6 ABI? My understanding is that Ncurses 6 provides a build-time option as to whether it will support ABI version 5 or 6.

There are features I would like to use from the Ncurses 6 ABI, specifically extended color pairs, which have never worked for me in Python (despite curses.has_extended_color_support() returning True across multiple versions, including the current python.org binaries).

If this isn't a good place to ask, then I apologize and will try to put it into a real bug report. Thanks.

@human3 human3 mentioned this issue Sep 2, 2024
Open
ned-deily added a commit to ned-deily/cpython that referenced this issue Feb 11, 2025
@ned-deily
pythongh-91132: Update macOS installer to use ncurses 6.5.
66c93d9
ned-deily added a commit to ned-deily/cpython that referenced this issue Feb 11, 2025
@ned-deily
pythongh-91132: Update macOS installer to use ncurses 6.5.
677b805
@bedevere-app bedevere-app bot mentioned this issue Feb 11, 2025
Merged
@ned-deily ned-deily changed the title Update macOS installer builds to use ncurses 6.3 Update macOS installer builds to use ncurses 6.5 Feb 11, 2025
ned-deily added a commit that referenced this issue Feb 11, 2025
@ned-deily
gh-91132: Update macOS installer to use ncurses 6.5. (#129990)
0dbe543
@hugovk hugovk removed the 3.11 only security fixes label Mar 17, 2025
ned-deily added a commit to ned-deily/cpython that referenced this issue Apr 7, 2025
@ned-deily
pythongh-91132: Update macOS installer to use ncurses 6.5. (python#12…
d9e329c 
…9990)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 7, 2025
@ned-deily @miss-islington
pythongh-91132: Update macOS installer to use ncurses 6.5. (pythonGH-…
a2903f0 
…129990)

(cherry picked from commit 0dbe543)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-app bedevere-app bot mentioned this issue Apr 7, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 7, 2025
@ned-deily @miss-islington
pythongh-91132: Update macOS installer to use ncurses 6.5. (pythonGH-…
2c15e31 
…129990)

(cherry picked from commit 0dbe543)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-app bedevere-app bot mentioned this issue Apr 7, 2025
Merged
ned-deily added a commit that referenced this issue Apr 7, 2025
@miss-islington @ned-deily
[3.13] gh-91132: Update macOS installer to use ncurses 6.5. (GH-129990)
2458f1c 
(cherry picked from commit 0dbe543)

Co-authored-by: Ned Deily <nad@python.org>
ned-deily added a commit that referenced this issue Apr 7, 2025
@miss-islington @ned-deily
[3.12] gh-91132: Update macOS installer to use ncurses 6.5. (GH-129990)
81445c2 
(cherry picked from commit 0dbe543)

Co-authored-by: Ned Deily <nad@python.org>
@ned-deily
Copy link
Member Author

As of the Python 3.14.0 alpha 5 pre-release and the upcoming 3.13.3 and 3.12.10 releases, python.org macOS installers now build and link with ncurses 6.5, the current stable release.

@cmang, to answer your question from long ago:

would this update mean that Python for macOS would switch from using the Ncurses 5 ABI to the Ncurses 6 ABI?

Yes. If you are still following along, let us know if extended color pairs does not work.

@github-project-automation github-project-automation bot moved this from Build to Done in Curses issues Apr 7, 2025
@ned-deily ned-deily marked this as a duplicate of #128085 Apr 7, 2025
@ned-deily ned-deily marked this as a duplicate of #129326 Apr 7, 2025
@brianschubert brianschubert mentioned this issue Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ned-deily ned-deily

Labels
3.12 only security fixes 3.13 bugs and security fixes build The build process and cross-build OS-mac type-security A security issue
Projects
Curses issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@gpshead @vstinner @cmang @ronaldoussoren @hugovk @ned-deily @erlend-aasland
0