8000 `cursesmodule` uses `winobj` which might be `NULL` · Issue #123913 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
cursesmodule uses winobj which might be NULL #123913
New issue
New issue
Closed as not planned
Closed as not planned
cursesmodule uses winobj which might be NULL#123913
Assignees
sobolevn
Labels
extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error
@sobolevn

Description

@sobolevn
sobolevn
opened on Sep 10, 2024

Bug report

Here's the problematic code:

cpython/Modules/_cursesmodule.c

Lines 3365 to 3367 in a2d0818

winobj = (PyCursesWindowObject *)PyCursesWindow_New(win, NULL);
screen_encoding = winobj->encoding;
return (PyObject *)winobj;

Why is it problematic? Because PyCursesWindow_New can return NULL here:

cpython/Modules/_cursesmodule.c

Lines 708 to 712 in a2d0818

if (wo->encoding == NULL) {
Py_DECREF(wo);
PyErr_NoMemory();
return NULL;
}

So, winobj->encoding of NULL is not good :(

I will send a PR.

Linked PRs

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    0