8000 Refactor operators · Issue #115830 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Refactor operators #115830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThexXTURBOXx opened this issue Feb 22, 2024 · 2 comments
Closed

Refactor operators #115830

ThexXTURBOXx opened this issue Feb 22, 2024 · 2 comments

Comments

@ThexXTURBOXx
Copy link
Contributor
ThexXTURBOXx commented Feb 22, 2024 •
edited
Loading

Reviews #115814 (comment), #115814 (comment), and #115814 (comment) show that there are a few things to refactor and/or optimize in regard to operators.
Furthermore, the documentation is sometimes rather hard to read without quotes, such as e.g., "Same as a is None." (which would be much better as "Same as 'a is None'." like @sobolevn proposed).

TODO:
@ThexXTURBOXx ThexXTURBOXx mentioned this issue Feb 22, 2024
Merged
@sobolevn
Copy link
Member

My 2c: the whole module refactoring is usually not-a-so-good idea :)
It might introduce new bugs, it damages the git history and does not bring us much value.

So, let's wait for some other voices: do people find this valuable enough? Or maybe they don't :)

I personally think that adding 'a is None' is a good idea, it make the docs much nicer. But, adding PyBool_FromLong is very optional.

@rhettinger
Copy link
Contributor

I agree with sobolevn that whole module refactoring isn't warranted here. It would be a lot of code churn but offer zero value to the end user.

@rhettinger rhettinger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhettinger @sobolevn @ThexXTURBOXx
0