8000 Improve test cases for type substitution of a list of types after initial ParamSpec substitution · Issue #103054 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve test cases for type substitution of a list of types after initial ParamSpec substitution #103054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Mar 27, 2023 · 1 comment
Closed

Improve test cases for type substitution of a list of types after initial ParamSpec substitution #103054

sobolevn opened this issue Mar 27, 2023 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member
sobolevn commented Mar 27, 2023 •
edited by bedevere-bot
Loading

After merging #102808 I realized that I've missed several important cases.

Right now substitution algorithm has these lines:

cpython/Lib/typing.py

Lines 1477 to 1488 in 2cdc518

if self.__origin__ == collections.abc.Callable and isinstance(new_arg, tuple):
# Consider the following `Callable`.
# C = Callable[[int], str]
# Here, `C.__args__` should be (int, str) - NOT ([int], str).
# That means that if we had something like...
# P = ParamSpec('P')
# T = TypeVar('T')
# C = Callable[P, T]
# D = C[[int, str], float]
# ...we need to be careful; `new_args` should end up as
# `(int, str, float)` rather than `([int, str], float)`.
new_args.extend(new_arg)

It is tested. But, it is never tested for the nested arguments:

cpython/Lib/typing.py

Lines 1500 to 1511 in 2cdc518

elif isinstance(old_arg, tuple):
# Corner case:
# P = ParamSpec('P')
# T = TypeVar('T')
# class Base(Generic[P]): ...
# Can be substituted like this:
# X = Base[[int, T]]
# In this case, `old_arg` will be a tuple:
new_args.append(
tuple(self._make_substitution(old_arg, new_arg_by_param)),
)
else:

I think that Callable is complex and important enought to be covered with as many cases as possible. Furthermore, Callable can be nested deeply in real types and we need to be sure that this use-case works as intended.

I will send a PR with more tests :)

Related #88965

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Mar 27, 2023
@sobolevn sobolevn self-assigned this Mar 27, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 27, 2023
@sobolevn
pythongh-103054: Improve Callable type subtitution tests
be50575
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 27, 2023
@sobolevn
pythongh-103054: Improve Callable type subtitution tests
12a9668
@bedevere-bot bedevere-bot mentioned this issue Mar 27, 2023
Merged
JelleZijlstra pushed a commit that referenced this issue Mar 29, 2023
@sobolevn @AlexWaygood @Eclips4
gh-103054: typing: Improve Callable type substitution tests (#103055)
60bdc16 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Mar 29, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 29, 2023
@sobolevn @AlexWaygood
@Eclips4 @miss-islington
pythongh-103054: typing: Improve Callable type substitution tests (p…
8e06aa8 
…ythonGH-103055)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington added a commit that referenced this issue Mar 29, 2023
@miss-islington @sobolevn
@AlexWaygood @Eclips4
gh-103054: typing: Improve Callable type substitution tests (GH-103055
766038d 
)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@AlexWaygood
Copy link
Member

Thanks Nikita!

warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@sobolevn @AlexWaygood
@Eclips4 @warsaw
pythongh-103054: typing: Improve Callable type substitution tests (p…
d067d26 
…ython#103055)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@favll favll mentioned this issue Jul 31, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood
0