Remove special-casing from `FORMAT_VALUE` opcode

Right now there's a special case in handling this opcode:

https://github.com/python/cpython/blob/5ffdaf748d98da6065158534720f1996a45a0072/Python/bytecodes.c#L3060-L3073

It comes from older version of `ceval.c`:

https://github.com/python/cpython/blob/281078794f10a42d0aa99d660e25a434fde96ec4/Python/ceval.c#L4379-L4395

But, I think that the needed optimizaion is there: https://github.com/python/cpython/blob/5ffdaf748d98da6065158534720f1996a45a0072/Objects/abstract.c#L774-L777

So, I think this can be safely removed.
I will send a PR.


### Linked PRs
* gh-102599

	/* If value is a unicode object, and there's no fmt_spec,
	then we know the result of format(value) is value
	itself. In that case, skip calling format(). I plan to
	move this optimization in to PyObject_Format()
	itself. */
	if (PyUnicode_CheckExact(value) && fmt_spec == NULL) {
	/* Do nothing, just transfer ownership to result. */
	result = value;
	} else {
	/* Actually call format(). */
	result = PyObject_Format(value, fmt_spec);
	Py_DECREF(value);
	Py_XDECREF(fmt_spec);
	ERROR_IF(result == NULL, error);

	/* If value is a unicode object, and there's no fmt_spec,
	then we know the result of format(value) is value
	itself. In that case, skip calling format(). I plan to
	move this optimization in to PyObject_Format()
	itself. */
	if (PyUnicode_CheckExact(value) && fmt_spec == NULL) {
	/* Do nothing, just transfer ownership to result. */
	result = value;
	} else {
	/* Actually call format(). */
	result = PyObject_Format(value, fmt_spec);
	Py_DECREF(value);
	Py_XDECREF(fmt_spec);
	if (result == NULL) {
	goto error;
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if (format_spec == NULL \|\| PyUnicode_GET_LENGTH(format_spec) == 0) {
	if (PyUnicode_CheckExact(obj)) {
	return Py_NewRef(obj);
	}

Uh oh!

Description

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions