10000 [3.13] gh-63882: Implement some `test_minidom` tests (GH-132879) (#13… · python/cpython@fdcaaad · GitHub
[go: up one dir, main page]

Skip to content

Commit fdcaaad

Browse files
miss-islingtonStanFromIrelandJulianGindihugovkpicnixz
authored
[3.13] gh-63882: Implement some test_minidom tests (GH-132879) (#133029)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Julian Gindi <julian@gindi.io> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
1 parent 3a1a2a0 commit fdcaaad

File tree

1 file changed

+32
-9
lines changed

1 file changed

+32
-9
lines changed

Lib/test/test_minidom.py

Lines changed: 32 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -396,13 +396,28 @@ def testChangeAttr(self):
396396
dom.unlink()
397397

398398
def testGetAttrList(self):
399-
pass
399+
dom = parseString("<abc/>")
400+
self.addCleanup(dom.unlink)
401+
el = dom.documentElement
402+
el.setAttribute("spam", "jam")
403+
self.assertEqual(len(el.attributes.items()), 1)
404+
el.setAttribute("foo", "bar")
405+
items = el.attributes.items()
406+
self.assertEqual(len(items), 2)
407+
self.assertIn(('spam', 'jam'), items)
408+
self.assertIn(('foo', 'bar'), items)
400409

401410
def testGetAttrValues(self):
402-
pass
403-
404-
def testGetAttrLength(self):
405-
pass
411+
dom = parseString("<abc/>")
412+
self.addCleanup(dom.unlink)
413+
el = dom.documentElement
414+
el.setAttribute("spam", "jam")
415+
values = [x.value for x in el.attributes.values()]
416+
self.assertIn("jam", values)
417+
el.setAttribute("foo", "bar")
418+
values = [x.value for x in el.attributes.values()]
419+
self.assertIn("bar", values)
420+
self.assertIn("jam", values)
406421

407422
def testGetAttribute(self):
408423
dom = Document()
@@ -496,8 +511,6 @@ def testAttributeRepr(self):
496511
self.assertEqual(str(node), repr(node))
497512
dom.unlink()
498513

499-
def testTextNodeRepr(self): pass
500-
501514
def testWriteXML(self):
502515
str = '<?xml version="1.0" ?><a b="c"/>'
503516
dom = parseString(str)
@@ -601,9 +614,19 @@ def testProcessingInstruction(self):
601614
and pi.localName is None
602615
and pi.namespaceURI == xml.dom.EMPTY_NAMESPACE)
603616

604-
def testProcessingInstructionRepr(self): pass
617+
def testProcessingInstructionRepr(self):
618+
dom = parseString('<e><?mypi \t\n data \t\n ?></e>')
619+
pi = dom.documentElement.firstChild
620+
self.assertEqual(str(pi.nodeType), repr(pi.nodeType))
605621

606-
def testTextRepr(self): pass
622+
def testTextRepr(self):
623+
dom = Document()
624+
self.addCleanup(dom.unlink)
625+
elem = dom.createElement("elem")
626+
elem.appendChild(dom.createTextNode("foo"))
627+
el = elem.firstChild
628+
self.assertEqual(str(el), repr(el))
629+
self.assertEqual('<DOM Text node "\'foo\'">', str(el))
607630

608631
def testWriteText(self): pass
609632

0 commit comments

Comments
 (0)
0