pass ssl context by argument

ggqlq · ggqlq · commit fc741e9c86bf · 2025-05-19T22:42:07.000+08:00
diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
@@ -1472,13 +1472,7 @@ def setUp(self):
             f.write(self.tls_password.encode())
         self.addCleanup(os_helper.unlink, self.tls_password_file)
 
-    def fetch_file(self, path):
-        context = None
-        if ssl is not None:
-            context = ssl.create_default_context()
-            # allow self-signed certificates
-            context.check_hostname = False
-            context.verify_mode = ssl.CERT_NONE
+    def fetch_file(self, path, context=None):
         req = urllib.request.Request(path, method='GET')
         with urllib.request.urlopen(req, context=context) as res:
             return res.read()
@@ -1524,6 +1518,11 @@ def test_http_client(self):
 
     @unittest.skipIf(ssl is None, "requires ssl")
     def test_https_client(self):
+        context = ssl.create_default_context()
+        # allow self-signed certificates
+        context.check_hostname = False
+        context.verify_mode = ssl.CERT_NONE
+
         port = find_unused_port()
         bind = '127.0.0.1'
         proc = spawn_python('-u', '-m', 'http.server', str(port), '-b', bind,
@@ -1534,7 +1533,8 @@ def test_https_client(self):
         self.addCleanup(kill_python, proc)
         self.addCleanup(proc.terminate)
         self.assertTrue(self.wait_for_server(proc, 'https', port, bind))
-        res = self.fetch_file(f'https://{bind}:{port}/{self.served_file_name}')
+        res = self.fetch_file(f'https://{bind}:{port}/{self.served_file_name}',
+                              context=context)
         self.assertEqual(res, self.served_data)
 
 
