Remove uncessary locking

corona10 · corona10 · commit fbb996478e3d · 2024-04-18T02:38:56.000+09:00
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -1287,12 +1287,10 @@ list_extend_set(PyListObject *self, PySetObject *other)
     Py_hash_t hash;
     PyObject *key;
     PyObject **dest = self->ob_item + m;
-    Py_BEGIN_CRITICAL_SECTION(other);
     while (_PySet_NextEntry((PyObject *)other, &setpos, &key, &hash)) {
         FT_ATOMIC_STORE_PTR_RELEASE(*dest, key);
         dest++;
     }
-    Py_END_CRITICAL_SECTION();
     Py_SET_SIZE(self, m + n);
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1287,12 +1287,10 @@ list_extend_set(PyListObject self, PySetObject other)`
`1287`	`1287`	`Py_hash_t hash;`
`1288`	`1288`	`PyObject *key;`
`1289`	`1289`	`PyObject **dest = self->ob_item + m;`
`1290`		`- Py_BEGIN_CRITICAL_SECTION(other);`
`1291`	`1290`	`while (_PySet_NextEntry((PyObject *)other, &setpos, &key, &hash)) {`
`1292`	`1291`	`FT_ATOMIC_STORE_PTR_RELEASE(* 5820 dest, key);`
`1293`	`1292`	`dest++;`
`1294`	`1293`	`}`
`1295`		`- Py_END_CRITICAL_SECTION();`
`1296`	`1294`	`Py_SET_SIZE(self, m + n);`
`1297`	`1295`	`return 0;`
`1298`	`1296`	`}`