bpo-43637: Fix a possible memory leak in winreg.SetValueEx() (GH-25038)

miss-islington · ZackerySpytz · web-flow · commit f79577ddbd7c · 2021-03-30T00:51:55.000-07:00
(cherry picked from commit dfeec34) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/PC/winreg.c b/PC/winreg.c
@@ -1788,6 +1788,7 @@ winreg_SetValueEx_impl(PyObject *module, HKEY key,
     if (PySys_Audit("winreg.SetValue", "nunO",
                     (Py_ssize_t)key, value_name, (Py_ssize_t)type,
                     value) < 0) {
+        PyMem_Free(data);
         return NULL;
     }
     Py_BEGIN_ALLOW_THREADS

Original file line number	Diff line number	Diff line change
`@@ -1788,6 +1788,7 @@ winreg_SetValueEx_impl(PyObject *module, HKEY key,`
`1788`	`1788`	`if (PySys_Audit("winreg.SetValue", "nunO",`
`1789`	`1789`	`(Py_ssize_t)key, value_name, (Py_ssize_t)type,`
`1790`	`1790`	`value) < 0) {`
	`1791`	`+ PyMem_Free(data);`
`1791`	`1792`	`return NULL;`
`1792`	`1793`	`}`
`1793`	`1794`	`Py_BEGIN_ALLOW_THREADS`