Add a note.

ericsnowcurrently · ericsnowcurrently · commit f5da08808d8c · 2023-05-08T08:03:48.000-06:00
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -300,7 +300,12 @@ _PyDict_DebugMallocStats(FILE *out)
 
 static void free_keys_object(PyInterpreterState *interp, PyDictKeysObject *keys);
 
-// XXX Switch to Py_INCREF()?
+/* We might consider modifying PyDictKeysObject so we could use
+   Py_INCREF() instead of dictkeys_incref() (and likewise with
+   Py_DECREF() and dictkeys_decref()).  However, there doesn't
+   seem to be enough benefit (performance or otherwise) to justify
+   the change. */
+
 static inline void
 dictkeys_incref(PyDictKeysObject *dk)
 {
@@ -313,7 +318,6 @@ dictkeys_incref(PyDictKeysObject *dk)
     dk->dk_refcnt++;
 }
 
-// XXX Switch to Py_DECREF()?
 static inline void
 dictkeys_decref(PyInterpreterState *interp, PyDictKeysObject *dk)
 {

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,12 @@ _PyDict_DebugMallocStats(FILE *out)`
`300`	`300`
`301`	`301`	`static void free_keys_object(PyInterpreterState interp, PyD 8000 ictKeysObject keys);`
`302`	`302`
`303`		`-// XXX Switch to Py_INCREF()?`
	`303`	`+/* We might consider modifying PyDictKeysObject so we could use`
	`304`	`+ Py_INCREF() instead of dictkeys_incref() (and likewise with`
	`305`	`+ Py_DECREF() and dictkeys_decref()). However, there doesn't`
	`306`	`+ seem to be enough benefit (performance or otherwise) to justify`
	`307`	`+ the change. */`
	`308`	`+`
`304`	`309`	`static inline void`
`305`	`310`	`dictkeys_incref(PyDictKeysObject *dk)`
`306`	`311`	`{`
`@@ -313,7 +318,6 @@ dictkeys_incref(PyDictKeysObject *dk)`
`313`	`318`	`dk->dk_refcnt++;`
`314`	`319`	`}`
`315`	`320`
`316`		`-// XXX Switch to Py_DECREF()?`
`317`	`321`	`static inline void`
`318`	`322`	`dictkeys_decref(PyInterpreterState interp, PyDictKeysObject dk)`
`319`	`323`	`{`