bpo-34735: Fix a memory leak in Modules/timemodule.c (GH-9418)

miss-islington · ZackerySpytz · web-flow · commit f37496e893d7 · 2018-09-21T00:41:42.000-07:00
There was a missing PyMem_Free(format) in time_strftime(). (cherry picked from commit 91e6c87) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst b/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst
@@ -0,0 +1 @@
+Fix a memory leak in Modules/timemodule.c.  Patch by Zackery Spytz.
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
@@ -654,6 +654,7 @@ time_strftime(PyObject *self, PyObject *args)
         if (outbuf[1] == L'y' && buf.tm_year < 0) {
             PyErr_SetString(PyExc_ValueError,
                             "format %y requires year >= 1900 on AIX");
+            PyMem_Free(format);
             return NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix a memory leak in Modules/timemodule.c. Patch by Zackery Spytz.`
Original file line number	Diff line number	Diff line change
`@@ -654,6 +654,7 @@ time_strftime(PyObject self, PyObject args)`
`654`	`654`	`if (outbuf[1] == L'y' && buf.tm_year < 0) {`
`655`	`655`	`PyErr_SetString(PyExc_ValueError,`
`656`	`656`	`"format %y requires year >= 1900 on AIX");`
	`657`	`+ PyMem_Free(format);`
`657`	`658`	`return NULL;`
`658`	`659`	`}`
`659`	`660`	`}`