bpo-40826: PyOS_InterruptOccurred() requires GIL (GH-20578)

vstinner · vstinner · commit f279e5bf224b · 2020-06-03T18:36:14.000+02:00
PyOS_InterruptOccurred() now fails with a fatal error if it is called with the GIL released. (cherry picked from commit cbe1296)
diff --git a/Misc/NEWS.d/next/C API/2020-06-01-16-12-37.bpo-40826.zQzFoK.rst b/Misc/NEWS.d/next/C API/2020-06-01-16-12-37.bpo-40826.zQzFoK.rst
@@ -0,0 +1,2 @@
+:c:func:`PyOS_InterruptOccurred` now fails with a fatal error if it is
+called with the GIL released.
diff --git a/Modules/signalmodule.c b/Modules/signalmodule.c
@@ -1784,7 +1784,7 @@ PyOS_FiniInterrupts(void)
 int
 _PyOS_InterruptOccurred(PyThreadState *tstate)
 {
-    assert(tstate != NULL);
+    _Py_EnsureTstateNotNULL(tstate);
     if (!_Py_ThreadCanHandleSignals(tstate->interp)) {
         return 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+:c:func:`PyOS_InterruptOccurred` now fails with a fatal error if it is
	`2`	`+called with the GIL released.`
Original file line number	Diff line number	Diff line change
`@@ -1784,7 +1784,7 @@ PyOS_FiniInterrupts(void)`
`1784`	`1784`	`int`
`1785`	`1785`	`_PyOS_InterruptOccurred(PyThreadState *tstate)`
`1786`	`1786`	`{`
`1787`		`- assert(tstate != NULL);`
	`1787`	`+ _Py_EnsureTstateNotNULL(tstate);`
`1788`	`1788`	`if (!_Py_ThreadCanHandleSignals(tstate->interp)) {`
`1789`	`1789`	`return 0;`
`1790`	`1790`	`}`