gh-111789: Use PyDict_GetItemRef() in Modules/_threadmodule.c (gh-112077)

serhiy-storchaka · web-flow · commit ef9b2fc9b037 · 2023-11-27T18:46:43.000+01:00
diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
@@ -1115,12 +1115,10 @@ local_getattro(localobject *self, PyObject *name)
     }
 
     /* Optimization: just look in dict ourselves */
-    PyObject *value = PyDict_GetItemWithError(ldict, name);
-    if (value != NULL) {
-        return Py_NewRef(value);
-    }
-    if (PyErr_Occurred()) {
-        return NULL;
+    PyObject *value;
+    if (PyDict_GetItemRef(ldict, name, &value) != 0) {
+        // found or error
+        return value;
     }
 
     /* Fall back on generic to get __class__ and __dict__ */
