gh-106843: fix memleak in _PyCompile_CleanDoc (#106846)

methane · web-flow · commit ece3b9d12a2f · 2023-07-18T03:44:16.000Z
diff --git a/Python/compile.c b/Python/compile.c
@@ -2267,6 +2267,7 @@ compiler_function_body(struct compiler *c, stmt_ty s, int is_async, Py_ssize_t f
         }
     }
     if (compiler_add_const(c->c_const_cache, c->u, docstring ? docstring : Py_None) < 0) {
+        Py_XDECREF(docstring);
         compiler_exit_scope(c);
         return ERROR;
     }
@@ -8060,7 +8061,9 @@ _PyCompile_CleanDoc(PyObject *doc)
     }
 
     Py_DECREF(doc);
-    return PyUnicode_FromStringAndSize(buff, w - buff);
+    PyObject *res = PyUnicode_FromStringAndSize(buff, w - buff);
+    PyMem_Free(buff);
+    return res;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -2267,6 +2267,7 @@ compiler_function_body(struct compiler *c, stmt_ty s, int is_async, Py_ssize_t f`
`2267`	`2267`	`}`
`2268`	`2268`	`}`
`2269`	`2269`	`if (compiler_add_const(c->c_const_cache, c->u, docstring ? docstring : Py_None) < 0) {`
	`2270`	`+ Py_XDECREF(docstring);`
`2270`	`2271`	`compiler_exit_scope(c);`
`2271`	`2272`	`return ERROR;`
`2272`	`2273`	`}`
`@@ -8060,7 +8061,9 @@ _PyCompile_CleanDoc(PyObject *doc)`
`8060`	`8061`	`}`
`8061`	`8062`
`8062`	`8063`	`Py_DECREF(doc);`
`8063`		`- return PyUnicode_FromStringAndSize(buff, w - buff);`
	`8064`	`+ PyObject *res = PyUnicode_FromStringAndSize(buff, w - buff);`
	`8065`	`+ PyMem_Free(buff);`
	`8066`	`+ return res;`
`8064`	`8067`	`}`
`8065`	`8068`
`8066`	`8069`