Use Py_UNREACHABLE

emmatyping · emmatyping · commit e825285e8f63 · 2025-05-01T16:46:50.000-07:00
diff --git a/Modules/_zstd/compressor.c b/Modules/_zstd/compressor.c
@@ -277,10 +277,7 @@ _PyZstd_load_c_dict(ZstdCompressor *self, PyObject *dict) {
         Py_END_CRITICAL_SECTION2();
     }
     else {
-        /* Impossible code path */
-        PyErr_SetString(PyExc_SystemError,
-                        "load_c_dict() impossible code path");
-        return -1;
+        Py_UNREACHABLE();
     }
 
     /* Check error */

Original file line number	Diff line number	Diff line change
`@@ -277,10 +277,7 @@ _PyZstd_load_c_dict(ZstdCompressor self, PyObject dict) {`
`277`	`277`	`Py_END_CRITICAL_SECTION2();`
`278`	`278`	`}`
`279`	`279`	`else {`
`280`		`- /* Impossible code path */`
`281`		`- PyErr_SetString(PyExc_SystemError,`
`282`		`- "load_c_dict() impossible code path");`
`283`		`- return -1;`
	`280`	`+ Py_UNREACHABLE();`
`284`	`281`	`}`
`285`	`282`
`286`	`283`	`/* Check error */`