Fixes for refcount tests

eduardo-elizondo · eduardo-elizondo · commit e530f0be5cce · 2021-12-18T11:04:14.000-08:00
diff --git a/Include/object.h b/Include/object.h
@@ -512,12 +512,12 @@ static inline void _Py_INCREF(PyObject *op)
 #else
     // Non-limited C API and limited C API for Python 3.9 and older access
     // directly PyObject.ob_refcnt.
-#ifdef Py_REF_DEBUG
-    _Py_RefTotal++;
-#endif
     if (_Py_IsImmortal(op)) {
         return;
     }
+#ifdef Py_REF_DEBUG
+    _Py_RefTotal++;
+#endif
     op->ob_refcnt++;
 #endif
 }
@@ -535,12 +535,12 @@ static inline void _Py_DECREF(
 #else
     // Non-limited C API and limited C API for Python 3.9 and older access
     // directly PyObject.ob_refcnt.
-#ifdef Py_REF_DEBUG
-    _Py_RefTotal--;
-#endif
     if (_Py_IsImmortal(op)) {
         return;
     }
+#ifdef Py_REF_DEBUG
+    _Py_RefTotal--;
+#endif
     if (--op->ob_refcnt != 0) {
 #ifdef Py_REF_DEBUG
         if (op->ob_refcnt < 0) {
diff --git a/Lib/test/t.py b/Lib/test/t.py
@@ -0,0 +1,10 @@
+import unittest
+
+GLOBAL_LIST = []
+
+class RefLeakTest(unittest.TestCase):
+    def test_leak(self):
+        GLOBAL_LIST.append(object())
+
+if __name__ == '__main__':
+    unittest.main()
diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
@@ -913,7 +913,7 @@ class RefLeakTest(unittest.TestCase):
                 def test_leak(self):
                     GLOBAL_LIST.append(object())
         """)
-        self.check_leak(code, 'references')
+        self.check_leak(code, 'memory blocks')
 
     @unittest.skipUnless(Py_DEBUG, 'need a debug build')
     def test_huntrleaks_fd_leak(self):
diff --git a/t.py b/t.py
@@ -0,0 +1,10 @@
+import unittest
+
+GLOBAL_LIST = []
+
+class RefLeakTest(unittest.TestCase):
+    def test_leak(self):
+        GLOBAL_LIST.append(object())
+
+if __name__ == '__main__':
+    unittest.main()
