Address review

Erlend Egeberg Aasland · zooba · Erlend E. Aasland · commit dd2ffdebf887 · 2021-04-25T01:12:52.000+02:00
Co-authored-by: Steve Dower &lt;steve.dower@microsoft.com&gt;
diff --git a/Lib/test/audit-tests.py b/Lib/test/audit-tests.py
@@ -370,16 +370,14 @@ def hook(event, *args):
     cx = sqlite3.connect(":memory:")
 
     # Configured without --enable-loadable-sqlite-extensions
-    if not hasattr(sqlite3.Connection, "enable_load_extension"):
-        return
-
-    cx.enable_load_extension(False)
-    try:
-        cx.load_extension("test")
-    except sqlite3.OperationalError:
-        pass
-    else:
-        raise RuntimeError("Expected sqlite3.load_extension to fail")
+    if hasattr(sqlite3.Connection, "enable_load_extension"):
+        cx.enable_load_extension(False)
+        try:
+            cx.load_extension("test")
+        except sqlite3.OperationalError:
+            pass
+        else:
+            raise RuntimeError("Expected sqlite3.load_extension to fail")
 
 
 if __name__ == "__main__":
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -1154,7 +1154,7 @@ pysqlite_connection_enable_load_extension_impl(pysqlite_Connection *self,
 {
     int rc;
 
-    if (PySys_Audit("sqlite3.enable_load_extension", "i", onoff) < 0) {
+    if (PySys_Audit("sqlite3.enable_load_extension", "O", onoff ? Py_True : Py_False) < 0) {
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1154,7 +1154,7 @@ pysqlite_connection_enable_load_extension_impl(pysqlite_Connection *self,`
`1154`	`1154`	`{`
`1155`	`1155`	`int rc;`
`1156`	`1156`
`1157`		`- if (PySys_Audit("sqlite3.enable_load_extension", "i", onoff) < 0) {`
	`1157`	`+ if (PySys_Audit("sqlite3.enable_load_extension", "O", onoff ? Py_True : Py_False) < 0) {`
`1158`	`1158`	`return NULL;`
`1159`	`1159`	`}`
`1160`	`1160`