Don't leak ref if initialization fails

mpage · mpage · commit d998d1b4ed18 · 2024-03-24T15:15:30.000-07:00
diff --git a/Objects/weakrefobject.c b/Objects/weakrefobject.c
@@ -179,6 +179,7 @@ new_weakref(PyObject *ob, PyObject *callback)
     result = PyObject_GC_New(PyWeakReference, &_PyWeakref_RefType);
     if (result) {
         if (init_weakref(result, ob, callback) < 0) {
+            Py_DECREF(result);
             return NULL;
         }
         PyObject_GC_Track(result);

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,7 @@ new_weakref(PyObject ob, PyObject callback)`
`179`	`179`	`result = PyObject_GC_New(PyWeakReference, &_PyWeakref_RefType);`
`180`	`180`	`if (result) {`
`181`	`181`	`if (init_weakref(result, ob, callback) < 0) {`
	`182`	`+ Py_DECREF(result);`
`182`	`183`	`return NULL;`
`183`	`184`	`}`
`184`	`185`	`PyObject_GC_Track(result);`