bpo-44864: Do not translate user-provided strings in ArgumentParser.add_subparsers() (GH-27667)

jdetrey · web-flow · commit d3c76dff4440 · 2024-09-24T19:54:50.000Z
Call _() on literal strings only.
diff --git a/Lib/argparse.py b/Lib/argparse.py
@@ -1804,8 +1804,8 @@ def add_subparsers(self, **kwargs):
         kwargs.setdefault('parser_class', type(self))
 
         if 'title' in kwargs or 'description' in kwargs:
-            title = _(kwargs.pop('title', 'subcommands'))
-            description = _(kwargs.pop('description', None))
+            title = kwargs.pop('title', _('subcommands'))
+            description = kwargs.pop('description', None)
             self._subparsers = self.add_argument_group(title, description)
         else:
             self._subparsers = self._positionals
diff --git a/Misc/NEWS.d/next/Library/2021-08-24-19-37-46.bpo-44864.KzxaDh.rst b/Misc/NEWS.d/next/Library/2021-08-24-19-37-46.bpo-44864.KzxaDh.rst
@@ -0,0 +1 @@
+Do not translate user-provided strings in :class:`argparse.ArgumentParser`.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Do not translate user-provided strings in :class:`argparse.ArgumentParser`.