8000 use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896) · python/cpython@cf25c5c · GitHub
[go: up one dir, main page]
Skip to content

Commit cf25c5c

Browse files
benjaminpbenjaminp
committed
use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
1 parent d9bed99 commit cf25c5c

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

‎Lib/test/test_ssl.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -690,20 +690,25 @@ def test_non_blocking_handshake(self):
690690

691691
def test_get_server_certificate(self):
692692
with support.transient_internet("svn.python.org"):
693-
pem = ssl.get_server_certificate(("svn.python.org", 443))
693+
pem = ssl.get_server_certificate(("svn.python.org", 443),
694+
ssl.PROTOCOL_SSLv23)
694695
if not pem:
695696
self.fail("No server certificate on svn.python.org:443!")
696697

697698
try:
698-
pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=CERTFILE)
699+
pem = ssl.get_server_certificate(("svn.python.org", 443),
700+
ssl.PROTOCOL_SSLv23,
701+
ca_certs=CERTFILE)
699702
except ssl.SSLError as x:
700703
#should fail
701704
if support.verbose:
702705
sys.stdout.write("%s\n" % x)
703706
else:
704707
self.fail("Got server certificate %s for svn.python.org!" % pem)
705708

706-
pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
709+
pem < 5538 span class=pl-c1>= ssl.get_server_certificate(("svn.python.org", 443),
710+
ssl.PROTOCOL_SSLv23,
711+
ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
707712
if not pem:
708713
self.fail("No server certificate on svn.python.org:443!")
709714
if support.verbose:

0 commit comments

Comments
 (0)
0