8000 bpo-34108: Fix double carriage return in 2to3 on Windows (#8271) · python/cpython@cafaf04 · GitHub
[go: up one dir, main page]

Skip to content

Commit cafaf04

Browse files
authored
bpo-34108: Fix double carriage return in 2to3 on Windows (#8271)
* Add test capturing failure. * Honor newlines as present in the original file.
1 parent 379e9d6 commit cafaf04

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

Lib/lib2to3/refactor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ def write_file(self, new_text, filename, old_text, encoding=None):
514514
set.
515515
"""
516516
try:
517-
fp = io.open(filename, "w", encoding=encoding)
517+
fp = io.open(filename, "w", encoding=encoding, newline='')
518518
except OSError as err:
519519
self.log_error("Can't create %s: %s", filename, err)
520520
return

Lib/lib2to3/tests/test_refactor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ def test_crlf_unchanged(self):
300300
old, new = self.refactor_file(fn)
301301
self.assertIn(b"\r\n", old)
302302
self.assertIn(b"\r\n", new)
303+
self.assertNotIn(b"\r\r\n", new)
303304

304305
def test_refactor_docstring(self):
305306
rt = self.rt()
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove extraneous CR in 2to3 refactor.

0 commit comments

Comments
 (0)
0