8000 bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) · python/cpython@c8fb58b · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c8fb58b

Browse files
vstinnerjkloth
andauthored
bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348)
bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines: * XML_NS * XML_DTD * BYTEORDER=1234 * XML_CONTEXT_BYTES=1024 * HAVE_MEMMOVE Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings. Co-Authored-By: Jeremy Kloth <jeremy.kloth@gmail.com>
1 parent 073ae48 commit c8fb58b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

PCbuild/_elementtree.vcxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<ItemDefinitionGroup>
6363
<ClCompile>
6464
<AdditionalIncludeDirectories>..\Modules\expat;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
65-
<PreprocessorDefinitions>XML_NS;XML_DTD;BYTEORDER=1234;XML_CONTEXT_BYTES=1024;USE_PYEXPAT_CAPI;XML_STATIC;HAVE_MEMMOVE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
65+
<PreprocessorDefinitions>USE_PYEXPAT_CAPI;XML_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
6666
</ClCompile>
6767
<Link>
6868
<BaseAddress>0x1D100000</BaseAddress>
@@ -103,4 +103,4 @@
103103
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
104104
<ImportGroup Label="ExtensionTargets">
105105
</ImportGroup>
106-
</Project>
106+
</Project>

0 commit comments

Comments
 (0)
0