8000 Address comment · python/cpython@c57f95b · GitHub
[go: up one dir, main page]

Skip to content

Commit c57f95b

Browse files
committed
Address comment
1 parent 77ffbe6 commit c57f95b

File tree

1 file changed

+12
-34
lines changed

1 file changed

+12
-34
lines changed

Lib/test/test_gettext.py

Lines changed: 12 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -939,46 +939,24 @@ def test_lazy_import(self):
939939
class DGettextTest(GettextBaseTest):
940940

941941
def setUp(self):
942-
GettextBaseTest.setUp(self)
942+
super().setUp()
943943
gettext.bindtextdomain('gettext', os.curdir)
944944

945-
def test_dgettext_found_translation(self):
946-
result = gettext.dgettext('gettext', 'mullusk')
947-
self.assertEqual(result, 'bacon')
945+
def test_dgettext_translation(self):
946+
translation_cases = [
947+
('gettext', 'mullusk', 'bacon'),
948+
('gettext', 'Raymond Luxury Yach-t', 'Throatwobbler Mangrove'),
949+
('gettext', 'nudge nudge', 'wink wink'),
948950

949-
def test_dgettext_fallback_cases(self):
950-
test_cases = [
951-
('gettext', 'missing message'),
952-
('nonexistent_domain', 'mullusk'),
953-
('', 'mullusk'),
951+
('gettext', 'missing message', 'missing message'),
952+
('nonexistent_domain', 'mullusk', 'mullusk'),
953+
('', 'mullusk', gettext.gettext('mullusk')),
954954
]
955-
for domain, message in test_cases:
956-
with self.subTest(domain=domain, message=message):
957-
result = gettext.dgettext(domain, message)
958-
if domain == '':
959-
expected = gettext.gettext(message)
960-
else:
961-
expected = message
955+
for domain, msgid, expected in translation_cases:
956+
with self.subTest(domain=domain, msgid=msgid):
957+
result = gettext.dgettext(domain, msgid)
962958
self.assertEqual(result, expected)
963959

964-
def test_dgettext_luxury_yacht_translation(self):
965-
result = gettext.dgettext('gettext', 'Raymond Luxury Yach-t')
966-
self.assertEqual(result, 'Throatwobbler Mangrove')
967-
968-
def test_dgettext_nudge_nudge_translation(self):
969-
result = gettext.dgettext('gettext', 'nudge nudge')
970-
self.assertEqual(result, 'wink wink')
971-
972-
def test_dgettext_multiline_translation(self):
973-
message = '''This module provides internationalization and localization
974-
support for your Python programs by providing an interface to the GNU
975-
gettext message catalog library.'''
976-
expected = '''Guvf zbqhyr cebivqrf vagreangvbanyvmngvba naq ybpnyvmngvba
977-
fhccbeg sbe lbhe Clguba cebtenzf ol cebivqvat na vagresnpr gb gur TAH
978-
trggrkg zrffntr pngnybt yvoenel.'''
979-
result = gettext.dgettext('gettext', message)
980-
self.assertEqual(result, expected)
981-
982960

983961
if __name__ == '__main__':
984962
unittest.main()

0 commit comments

Comments
 (0)
0