bpo-43399: Fix ElementTree.extend not working on iterators (GH-24751)

miss-islington · alexprengere · web-flow · commit c1079cde2a76 · 2021-03-30T14:32:55.000-07:00
(cherry picked from commit 51a85dd) Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
@@ -314,6 +314,9 @@ def test_simpleops(self):
         elem.extend([e])
         self.serialize_check(elem, '<body><tag /><tag2 /></body>')
         elem.remove(e)
+        elem.extend(iter([e]))
+        self.serialize_check(elem, '<body><tag /><tag2 /></body>')
+        elem.remove(e)
 
         element = ET.Element("tag", key="value")
         self.serialize_check(element, '<tag key="value" />') # 1
diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py
@@ -245,7 +245,7 @@ def extend(self, elements):
         """
         for element in elements:
             self._assert_is_element(element)
-        self._children.extend(elements)
+            self._children.append(element)
 
     def insert(self, index, subelement):
         """Insert *subelement* at position *index*."""
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1334,6 +1334,7 @@ Matheus Vieira Portela
 Davin Potts
 Guillaume Pratte
 Florian Preinstorfer
+Alex Prengère
 Amrit Prem
 Paul Prescod
 Donovan Preston
diff --git a/Misc/NEWS.d/next/Library/2021-03-04-17-53-46.bpo-43399.Wn95u-.rst b/Misc/NEWS.d/next/Library/2021-03-04-17-53-46.bpo-43399.Wn95u-.rst
@@ -0,0 +1,2 @@
+Fix ``ElementTree.extend`` not working on iterators when using the
+Python implementation

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix ``ElementTree.extend`` not working on iterators when using the
	`2`	`+Python implementation`