gh-131798: Optimize _UNARY_NEGATIVE (GH-135223)

noamcohen97 · web-flow · commit bda121862e7d · 2025-06-24T03:42:09.000+08:00
diff --git a/Lib/test/test_capi/test_opt.py b/Lib/test/test_capi/test_opt.py
@@ -2432,6 +2432,24 @@ def testfunc(n):
         self.assertIn("_POP_TOP_FLOAT", uops)
 
 
+    def test_unary_negative_long_float_type(self):
+        def testfunc(n):
+            for _ in range(n):
+                a = 9397
+                f = 9397.0
+                x = -a + -a
+                y = -f + -f
+
+        testfunc(TIER2_THRESHOLD)
+
+        ex = get_first_executor(testfunc)
+        self.assertIsNotNone(ex)
+        uops = get_opnames(ex)
+
+        self.assertNotIn("_GUARD_TOS_INT", uops)
+        self.assertNotIn("_GUARD_NOS_INT", uops)
+        self.assertNotIn("_GUARD_TOS_FLOAT", uops)
+        self.assertNotIn("_GUARD_NOS_FLOAT", uops)
 
 def global_identity(x):
     return x
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-06-06-19-17-22.gh-issue-131798.XoV8Eb.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-06-06-19-17-22.gh-issue-131798.XoV8Eb.rst
@@ -0,0 +1 @@
+Optimize ``_UNARY_NEGATIVE`` in JIT-compiled code.
diff --git a/Python/optimizer_bytecodes.c b/Python/optimizer_bytecodes.c
@@ -452,7 +452,13 @@ dummy_func(void) {
             res = sym_new_compact_int(ctx);
         }
         else {
-            res = sym_new_not_null(ctx);
+            PyTypeObject *type = sym_get_type(value);
+            if (type == &PyLong_Type || type == &PyFloat_Type) {
+                res = sym_new_type(ctx, type);
+            }
+            else {
+                res = sym_new_not_null(ctx);
+            }
         }
     }
 
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Optimize ``_UNARY_NEGATIVE`` in JIT-compiled code.
Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,13 @@ dummy_func(void) {`
`452`	`452`	`res = sym_new_compact_int(ctx);`
`453`	`453`	`}`
`454`	`454`	`else {`
`455`		`- res = sym_new_not_null(ctx);`
	`455`	`+ PyTypeObject *type = sym_get_type(value);`
	`456`	`+ if (type == &PyLong_Type \|\| type == &PyFloat_Type) {`
	`457`	`+ res = sym_new_type(ctx, type);`
	`458`	`+ }`
	`459`	`+ else {`
	`460`	`+ res = sym_new_not_null(ctx);`
	`461`	`+ }`
`456`	`462`	`}`
`457`	`463`	`}`
`458`	`464`