remove redundant assert and move another up to just after the value was calculated

iritkatriel · iritkatriel · commit bab900a5be9c · 2022-09-29T10:58:23.000+01:00
diff --git a/Python/compile.c b/Python/compile.c
@@ -7080,15 +7080,14 @@ stackdepth(basicblock *entryblock, int code_flags)
             if (new_depth > maxdepth) {
                 maxdepth = new_depth;
             }
-            assert(depth >= 0); /* invalid code or bug in stackdepth() */
             if (HAS_TARGET(instr->i_opcode)) {
                 effect = stack_effect(instr->i_opcode, instr->i_oparg, 1);
                 assert(effect != PY_INVALID_STACK_EFFECT);
                 int target_depth = depth + effect;
+                assert(target_depth >= 0); /* invalid code or bug in stackdepth() */
                 if (target_depth > maxdepth) {
                     maxdepth = target_depth;
                 }
-                assert(target_depth >= 0); /* invalid code or bug in stackdepth() */
                 stackdepth_push(&sp, instr->i_target, target_depth);
             }
             depth = new_depth;

Original file line number	Diff line number	Diff line change
`@@ -7080,15 +7080,14 @@ stackdepth(basicblock *entryblock, int code_flags)`
`7080`	`7080`	`if (new_depth > maxdepth) {`
`7081`	`7081`	`maxdepth = new_depth;`
`7082`	`7082`	`}`
`7083`		`- assert(depth >= 0); /* invalid code or bug in stackdepth() */`
`7084`	`7083`	`if (HAS_TARGET(instr->i_opcode)) {`
`7085`	`7084`	`effect = stack_effect(instr->i_opcode, instr->i_oparg, 1);`
`7086`	`7085`	`assert(effect != PY_INVALID_STACK_EFFECT);`
`7087`	`7086`	`int target_depth = depth + effect;`
	`7087`	`+ assert(target_depth >= 0); /* invalid code or bug in stackdepth() */`
`7088`	`7088`	`if (target_depth > maxdepth) {`
`7089`	`7089`	`maxdepth = target_depth;`
`7090`	`7090`	`}`
`7091`		`- assert(target_depth >= 0); /* invalid code or bug in stackdepth() */`
`7092`	`7091`	`stackdepth_push(&sp, instr->i_target, target_depth);`
`7093`	`7092`	`}`
`7094`	`7093`	`depth = new_depth;`