BUILD_SLICE

iritkatriel · iritkatriel · commit b8745d7caa2a · 2023-02-03T00:09:10.000Z
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -3037,22 +3037,12 @@ dummy_func(
             goto resume_frame;
         }
 
-        // error: BUILD_SLICE has irregular stack effect
-        inst(BUILD_SLICE) {
-            PyObject *start, *stop, *step, *slice;
-            if (oparg == 3)
-                step = POP();
-            else
-                step = NULL;
-            stop = POP();
-            start = TOP();
+        inst(BUILD_SLICE, (start, stop, step if (oparg == 3) -- slice)) {
             slice = PySlice_New(start, stop, step);
             Py_DECREF(start);
             Py_DECREF(stop);
             Py_XDECREF(step);
-            SET_TOP(slice);
-            if (slice == NULL)
-                goto error;
+            ERROR_IF(slice == NULL, error);
         }
 
         // error: FORMAT_VALUE has irregular stack effect
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
diff --git a/Python/opcode_metadata.h b/Python/opcode_metadata.h
@@ -329,7 +329,7 @@ _PyOpcode_num_popped(int opcode, int oparg, bool jump) {
         case RETURN_GENERATOR:
             return -1;
         case BUILD_SLICE:
-            return -1;
+            return ((oparg == 3) ? 1 : 0) + 2;
         case FORMAT_VALUE:
             return -1;
         case COPY:
@@ -675,7 +675,7 @@ _PyOpcode_num_pushed(int opcode, int oparg, bool jump) {
         case RETURN_GENERATOR:
             return -1;
         case BUILD_SLICE:
-            return -1;
+            return 1;
         case FORMAT_VALUE:
             return -1;
         case COPY:
