Address Petr's review

vstinner · vstinner · commit b43ce9e47cea · 2024-07-24T14:31:56.000+02:00
diff --git a/Doc/c-api/bytes.rst b/Doc/c-api/bytes.rst
@@ -195,6 +195,7 @@ called with a non-bytes parameter.
 
    *sep* must be Python :class:`bytes` object, or ``NULL`` which is treated as
    an empty bytes string.
+   (Note that the *sep* default is different from :c:func:`PyUnicode_Join`.)
 
    *iterable* must be an iterable object yielding objects that implement the
    :ref:`buffer protocol <bufferobjects>`.
diff --git a/Doc/whatsnew/3.14.rst b/Doc/whatsnew/3.14.rst
@@ -357,7 +357,7 @@ New Features
 
   (Contributed by Victor Stinner in :gh:`119182`.)
 
-* Add :c:func:`PyBytes_Join(seq, iterable) <PyBytes_Join>` function,
+* Add :c:func:`PyBytes_Join(sep, iterable) <PyBytes_Join>` function,
   similar to ``sep.join(iterable)`` in Python.
   (Contributed by Victor Stinner in :gh:`121645`.)
 
diff --git a/Lib/test/test_capi/test_bytes.py b/Lib/test/test_capi/test_bytes.py
@@ -266,7 +266,9 @@ def test_join(self):
 
         # invalid 'sep' argument type
         with self.assertRaises(TypeError):
-            bytes_join(bytearray('sep'), [])
+            bytes_join(bytearray(b'sep'), [])
+        with self.assertRaises(TypeError):
+            bytes_join(memoryview(b'sep'), [])
         with self.assertRaises(TypeError):
             bytes_join('', [])  # empty Unicode string
         with self.assertRaises(TypeError):
diff --git a/Misc/NEWS.d/next/C_API/2024-07-12-13-40-59.gh-issue-121645.96QvD3.rst b/Misc/NEWS.d/next/C_API/2024-07-12-13-40-59.gh-issue-121645.96QvD3.rst
@@ -1,2 +1,2 @@
-Add :c:func:`PyBytes_Join(seq, iterable) <PyBytes_Join>` function, similar to
+Add :c:func:`PyBytes_Join(sep, iterable) <PyBytes_Join>` function, similar to
 ``sep.join(iterable)`` in Python. Patch by Victor Stinner.

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		-Add :c:func:`PyBytes_Join(seq, iterable) <PyBytes_Join>` function, similar to
	`1`	+Add :c:func:`PyBytes_Join(sep, iterable) <PyBytes_Join>` function, similar to
`2`	`2`	``sep.join(iterable)`` in Python. Patch by Victor Stinner.