8000 bpo-42794: Update test_nntplib to use offical group name for testing … · python/cpython@b20d5e5 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b20d5e5

Browse files
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037)
(cherry picked from commit ec31653) Co-authored-by: Dong-hee Na <donghee.na@python.org>
1 parent 8333d42 commit b20d5e5

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9< 8000 /div>
-3
lines changed

Lib/test/test_nntplib.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def _check_desc(desc):
8282
desc = self.server.description(self.GROUP_NAME)
8383
_check_desc(desc)
8484
# Another sanity check
85-
self.assertIn("Python", desc)
85+
self.assertIn(self.DESC, desc)
8686
# With a pattern
8787
desc = self.server.description(self.GROUP_PAT)
8888
_check_desc(desc)
@@ -309,6 +309,7 @@ class NetworkedNNTPTests(NetworkedNNTPTestsMixin, unittest.TestCase):
309309
NNTP_HOST = 'news.trigofacile.com'
310310
GROUP_NAME = 'fr.comp.lang.python'
311311
GROUP_PAT = 'fr.comp.lang.*'
312+
DESC = 'Python'
312313

313314
NNTP_CLASS = NNTP
314315

@@ -343,8 +344,11 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
343344
# 400 connections per day are accepted from each IP address."
344345

345346
NNTP_HOST = 'nntp.aioe.org'
346-
GROUP_NAME = 'comp.lang.python'
347-
GROUP_PAT = 'comp.lang.*'
347+
# bpo-42794: aioe.test is one of the official groups on this server
348+
# used for testing: https://news.aioe.org/manual/aioe-hierarchy/
349+
GROUP_NAME = 'aioe.test'
350+
GROUP_PAT = 'aioe.*'
351+
DESC = 'test'
348352

349353
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)
350354

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Update test_nntplib to use offical group name of news.aioe.org for testing.
2+
Patch by Dong-hee Na.

0 commit comments

Comments
 (0)
0