bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827)

miss-islington · tiran · web-flow · commit a8936fa5c09c · 2020-06-13T09:15:05.000-07:00
Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 9672912) Co-authored-by: Christian Heimes <christian@python.org>
diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst
@@ -0,0 +1 @@
+Fix refleak in _Py_fopen_obj() when PySys_Audit() fails
diff --git a/Python/fileutils.c b/Python/fileutils.c
@@ -1461,6 +1461,7 @@ _Py_fopen_obj(PyObject *path, const char *mode)
     path_bytes = PyBytes_AS_STRING(bytes);
 
     if (PySys_Audit("open", "Osi", path, mode, 0) < 0) {
+        Py_DECREF(bytes);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix refleak in _Py_fopen_obj() when PySys_Audit() fails`
Original file line number	Diff line number	Diff line change
`@@ -1461,6 +1461,7 @@ _Py_fopen_obj(PyObject path, const char mode)`
`1461`	`1461`	`path_bytes = PyBytes_AS_STRING(bytes);`
`1462`	`1462`
`1463`	`1463`	`if (PySys_Audit("open", "Osi", path, mode, 0) < 0) {`
	`1464`	`+ Py_DECREF(bytes);`
`1464`	`1465`	`return NULL;`
`1465`	`1466`	`}`
`1466`	`1467`