gh-91217: deprecate nis (GH-91606)

brettcannon · web-flow · commit 9f06ff96ccbd · 2022-04-16T13:17:30.000-07:00
Automerge-Triggered-By: GH:brettcannon
diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst
@@ -882,6 +882,7 @@ Deprecated
   * :mod:`crypt`
   * :mod:`imghdr`
   * :mod:`msilib`
+  * :mod:`nis`
   * :mod:`nntplib`
 
   (Contributed by Brett Cannon in :issue:`47061`.)
diff --git a/Lib/test/test_nis.py b/Lib/test/test_nis.py
@@ -1,10 +1,13 @@
 from test import support
 from test.support import import_helper
 import unittest
+import warnings
 
 
 # Skip test if nis module does not exist.
-nis = import_helper.import_module('nis')
+with warnings.catch_warnings():
+    warnings.simplefilter("ignore", DeprecationWarning)
+    nis = import_helper.import_module('nis')
 
 
 class NisTests(unittest.TestCase):
diff --git a/Misc/NEWS.d/next/Library/2022-04-16-09-33-14.gh-issue-91217.nt9JFs.rst b/Misc/NEWS.d/next/Library/2022-04-16-09-33-14.gh-issue-91217.nt9JFs.rst
@@ -0,0 +1 @@
+Deprecate the nis module.
diff --git a/Modules/nismodule.c b/Modules/nismodule.c
@@ -524,5 +524,11 @@ static struct PyModuleDef nismodule = {
 PyMODINIT_FUNC
 PyInit_nis(void)
 {
+    if (PyErr_WarnEx(PyExc_DeprecationWarning,
+                     "'nis' is deprecated and slated for removal in "
+                     "Python 3.13",
+                     7)) {
+        return NULL;
+    }
     return PyModuleDef_Init(&nismodule);
 }

Original file line number	Diff line number	Diff line change
`@@ -524,5 +524,11 @@ static struct PyModuleDef nismodule = {`
`524`	`524`	`PyMODINIT_FUNC`
`525`	`525`	`PyInit_nis(void)`
`526`	`526`	`{`
	`527`	`+ if (PyErr_WarnEx(PyExc_DeprecationWarning,`
	`528`	`+ "'nis' is deprecated and slated for removal in "`
	`529`	`+ "Python 3.13",`
	`530`	`+ 7)) {`
	`531`	`+ return NULL;`
	`532`	`+ }`
`527`	`533`	`return PyModuleDef_Init(&nismodule);`
`528`	`534`	`}`