8000 Unmark files as executable that can't actually be executed. (GH-15353) · python/cpython@9ece4a5 · GitHub
[go: up one dir, main page]

Skip to content

Commit 9ece4a5

Browse files
gnpricemiss-islington
authored andcommitted
Unmark files as executable that can't actually be executed. (GH-15353)
There are plenty of legitimate scripts in the tree that begin with a `#!`, but also a few that seem to be marked executable by mistake. Found them with this command -- it gets executable files known to Git, filters to the ones that don't start with a `#!`, and then unmarks them as executable: $ git ls-files --stage \ | perl -lane 'print $F[3] if (!/^100644/)' \ | while read f; do head -c2 "$f" | grep -qxF '#!' \ || chmod a-x "$f"; \ done Looking at the list by hand confirms that we didn't sweep up any files that should have the executable bit after all. In particular * The `.psd` files are images from Photoshop. * The `.bat` files sure look like things that can be run. But we have lots of other `.bat` files, and they don't have this bit set, so it must not be needed for them. Automerge-Triggered-By: @benjaminp
1 parent 5b95a15 commit 9ece4a5

File tree

16 files changed

+1
-0
lines changed

16 files changed

+1
-0
lines changed

.azure-pipelines/posix-deps-apt.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#!/bin/sh
12
apt-get update
23

34
apt-get -yq install \

Doc/c-api/buffer.rst

100755100644
File mode changed.

Include/cpython/abstract.h

100755100644
File mode changed.

Lib/idlelib/idle.bat

100755100644
File mode changed.

Lib/test/test_buffer.py

100755100644
File mode changed.

Lib/test/test_dataclasses.py

100755100644
File mode changed.

Lib/test/test_importlib/test_abc.py

100755100644
File mode changed.

Lib/turtledemo/two_canvases.py

100755100644
File mode changed.

Mac/Resources/iconsrc/PythonCompiled.psd

100755100644
File mode changed.

Mac/Resources/iconsrc/PythonIcon.psd

100755100644
File mode changed.

Mac/Resources/iconsrc/PythonSource.psd

100755100644
File mode changed.

Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst

100755100644
File mode changed.

Modules/_decimal/tests/runall.bat

100755100644
File mode changed.

Modules/_testcapimodule.c

100755100644
File mode changed.

Modules/socketmodule.c

100755100644
File mode changed.

Modules/socketmodule.h

100755100644
File mode changed.

0 commit comments

Comments
 (0)
0