gh-126171: fix possible null dereference in _imp_find_frozen_impl (#126566)

federicovalenso · web-flow · commit 9ecd8f7f40e6 · 2024-11-08T15:49:15.000+05:30
diff --git a/Python/import.c b/Python/import.c
@@ -4424,7 +4424,7 @@ _imp_find_frozen_impl(PyObject *module, PyObject *name, int withdata)
     if (info.origname != NULL && info.origname[0] != '\0') {
         origname = PyUnicode_FromString(info.origname);
         if (origname == NULL) {
-            Py_DECREF(data);
+            Py_XDECREF(data);
             return NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -4424,7 +4424,7 @@ _imp_find_frozen_impl(PyObject module, PyObject name, int withdata)`
`4424`	`4424`	`if (info.origname != NULL && info.origname[0] != '\0') {`
`4425`	`4425`	`origname = PyUnicode_FromString(info.origname);`
`4426`	`4426`	`if (origname == NULL) {`
`4427`		`- Py_DECREF(data);`
	`4427`	`+ Py_XDECREF(data);`
`4428`	`4428`	`return NULL;`
`4429`	`4429`	`}`
`4430`	`4430`	`}`