Move Py_DECREF after PyErr_Format

donBarbos · donBarbos · commit 9da0dfca6b63 · 2024-11-29T16:31:41.000+04:00
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
@@ -1510,11 +1510,11 @@ call_tzinfo_method(PyObject *tzinfo, const char *name, PyObject *tzinfoarg)
                 GET_TD_SECONDS(offset) == 0 &&
                 GET_TD_MICROSECONDS(offset) < 1) ||
             GET_TD_DAYS(offset) < -1 || GET_TD_DAYS(offset) >= 1) {
-            Py_DECREF(offset);
             PyErr_Format(PyExc_ValueError, "offset must be a timedelta"
                          " strictly between -timedelta(hours=24) and"
                          " timedelta(hours=24),"
                          " not %R", offset);
+            Py_DECREF(offset);
             return NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1510,11 +1510,11 @@ call_tzinfo_method(PyObject tzinfo, const char name, PyObject *tzinfoarg)`
`1510`	`1510`	`GET_TD_SECONDS(offset) == 0 &&`
`1511`	`1511`	`GET_TD_MICROSECONDS(offset) < 1) \|\|`
`1512`	`1512`	`GET_TD_DAYS(offset) < -1 \|\| GET_TD_DAYS(offset) >= 1) {`
`1513`		`- Py_DECREF(offset);`
`1514`	`1513`	`PyErr_Format(PyExc_ValueError, "offset must be a timedelta"`
`1515`	`1514`	`" strictly between -timedelta(hours=24) and"`
`1516`	`1515`	`" timedelta(hours=24),"`
`1517`	`1516`	`" not %R", offset);`
	`1517`	`+ Py_DECREF(offset);`
`1518`	`1518`	`return NULL;`
`1519`	`1519`	`}`
`1520`	`1520`	`}`