8000 bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) · python/cpython@92f9024 · GitHub
[go: up one dir, main page]
Skip to content

Commit 92f9024

Browse files
miss-islingtonned-deily
miss-islington
and
ned-deily
committed
bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297)
`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only. https://bugs.python.org/issue35257 (cherry picked from commit 44a3ee0) Co-authored-by: Ned Deily <nad@python.org>
1 parent 26c94c3 commit 92f9024

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎Makefile.pre.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ CONFINCLUDEPY= $(CONFINCLUDEDIR)/python$(LDVERSION)
155155
SHLIB_SUFFIX= @SHLIB_SUFFIX@
156156
EXT_SUFFIX= @EXT_SUFFIX@
157157
LDSHARED= @LDSHARED@ $(PY_LDFLAGS)
158-
BLDSHARED= @BLDSHARED@ $(PY_LDFLAGS_NODIST)
158+
BLDSHARED= @BLDSHARED@ $(PY_CORE_LDFLAGS)
159159
LDCXXSHARED= @LDCXXSHARED@
160160
DESTSHARED= $(BINLIBDEST)/lib-dynload
161161

0 commit comments

Comments
 (0)
0