[3.9] gh-119690: Fixes buffer type confusion in _winapi.CreateFile and _winapi.CreateNamedPipe audit events (GH-119735) (#123679)

miss-islington · zooba · web-flow · commit 9290419492be · 2024-09-04T18:22:50.000+02:00
(cherry picked from commit 2e861ac) Co-authored-by: Steve Dower <steve.dower@python.org>
diff --git a/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst b/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst
@@ -0,0 +1,2 @@
+Fixes data type confusion in audit events raised by ``_winapi.CreateFile``
+and ``_winapi.CreateNamedPipe``.
diff --git a/Modules/_winapi.c b/Modules/_winapi.c
@@ -461,7 +461,7 @@ _winapi_CreateFile_impl(PyObject *module, LPCTSTR file_name,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateFile", "uIIII",
+    if (PySys_Audit("_winapi.CreateFile", "sIIII",
                     file_name, desired_access, share_mode,
                     creation_disposition, flags_and_attributes) < 0) {
         return INVALID_HANDLE_VALUE;
@@ -681,7 +681,7 @@ _winapi_CreateNamedPipe_impl(PyObject *module, LPCTSTR name, DWORD open_mode,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateNamedPipe", "uII",
+    if (PySys_Audit("_winapi.CreateNamedPipe", "sII",
                     name, open_mode, pipe_mode) < 0) {
         return INVALID_HANDLE_VALUE;
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fixes data type confusion in audit events raised by ``_winapi.CreateFile``
	`2`	+and ``_winapi.CreateNamedPipe``.
Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ _winapi_CreateFile_impl(PyObject *module, LPCTSTR file_name,`
`461`	`461`	`{`
`462`	`462`	`HANDLE handle;`
`463`	`463`
`464`		`- if (PySys_Audit("_winapi.CreateFile", "uIIII",`
	`464`	`+ if (PySys_Audit("_winapi.CreateFile", "sIIII",`
`465`	`465`	`file_name, desired_access, share_mode,`
`466`	`466`	`creation_disposition, flags_and_attributes) < 0) {`
`467`	`467`	`return INVALID_HANDLE_VALUE;`
`@@ -681,7 +681,7 @@ _winapi_CreateNamedPipe_impl(PyObject *module, LPCTSTR name, DWORD open_mode,`
`681`	`681`	`{`
`682`	`682`	`HANDLE handle;`
`683`	`683`
`684`		`- if (PySys_Audit("_winapi.CreateNamedPipe", "uII",`
	`684`	`+ if (PySys_Audit("_winapi.CreateNamedPipe", "sII",`
`685`	`685`	`name, open_mode, pipe_mode) < 0) {`
`686`	`686`	`return INVALID_HANDLE_VALUE;`
`687`	`687`	`}`