8000 Update Squeezer's tests given the latest changes · python/cpython@902091e · GitHub
[go: up one dir, main page]

Skip to content

Commit 902091e

Browse files
committed
Update Squeezer's tests given the latest changes
1 parent 53e74d9 commit 902091e

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

Lib/idlelib/idle_test/test_squeezer.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -176,18 +176,18 @@ def test_write_stdout(self):
176176
for text in ['', 'TEXT']:
177177
editwin.write = orig_write = Mock(return_value=SENTINEL_VALUE)
178178
squeezer = self.make_squeezer_instance(editwin)
179-
squeezer.get_auto_squeeze_min_lines = Mock(return_value=30)
179+
squeezer.auto_squeeze_min_lines = 30
180180

181181
self.assertEqual(squeezer.editwin.write(text, "stdout"),
182-
SENTINEL_VALUE)
182+
SENTINEL_VALUE)
183183
self.assertEqual(orig_write.call_count, 1)
184184
orig_write.assert_called_with(text, "stdout")
185185
self.assertEqual(len(squeezer.expandingbuttons), 0)
186186

187187
for text in ['LONG TEXT' * 1000, 'MANY_LINES\n' * 100]:
188188
editwin.write = orig_write = Mock(return_value=SENTINEL_VALUE)
189189
squeezer = self.make_squeezer_instance(editwin)
190-
squeezer.get_auto_squeeze_min_lines = Mock(return_value=30)
190+
squeezer.auto_squeeze_min_lines = 30
191191

192192
self.assertEqual(squeezer.editwin.write(text, "stdout"), None)
193193
self.assertEqual(orig_write.call_count, 0)
@@ -256,11 +256,9 @@ def test_preview_last_squeezed_event_no_squeezed(self):
256256
# is called and should fail (i.e. call squeezer.text.bell()).
257257
editwin = self.make_mock_editor_window()
258258
squeezer = self.make_squeezer_instance(editwin)
259-
squeezer.get_preview_command = Mock(return_value='notepad.exe %(fn)s')
260259

261260
retval = squeezer.preview_last_squeezed_event(event=Mock())
262261
self.assertEqual(retval, "break")
263-
self.assertEqual(squeezer.text.bell.call_count, 1)
264262

265263
def test_preview_last_squeezed_event(self):
266264
"""test the preview_last_squeezed event"""
@@ -283,6 +281,10 @@ def test_preview_last_squeezed_event(self):
283281
self.assertEqual(mock_expandingbutton2.preview.call_count, 1)
284282
mock_expandingbutton2.preview.assert_called_with(SENTINEL_VALUE)
285283

284+
squeezer.preview_last_squeezed_event(event=SENTINEL_VALUE)
285+
self.assertEqual(mock_expandingbutton1.preview.call_count, 0)
286+
self.assertEqual(mock_expandingbutton2.preview.call_count, 2)
287+
286288
def test_auto_squeeze(self):
287289
"""test that the auto-squeezing creates an ExpandingButton properly"""
288290
requires('gui')
@@ -292,7 +294,7 @@ def test_auto_squeeze(self):
292294
editwin = self.make_mock_editor_window()
293295
editwin.text = text_widget
294296
squeezer = self.make_squeezer_instance(editwin)
295-
squeezer.get_auto_squeeze_min_lines = Mock(return_value=5)
297+
squeezer.auto_squeeze_min_lines = 5
296298
squeezer.count_lines = Mock(return_value=6)
297299

298300
editwin.write('TEXT\n'*6, "stdout")
@@ -423,16 +425,16 @@ def make_mock_squeezer(self):
423425
squeezer.editwin.text = Text()
424426

425427
# Set default values for the configuration settings
426-
squeezer.get_max_num_of_lines = Mock(return_value=30)
427-
squeezer.get_show_tooltip = Mock(return_value=False)
428-
squeezer.get_tooltip_delay = Mock(return_value=1500)
428+
squeezer.auto_squeeze_min_lines = 30
429+
squeezer.should_show_tooltip = False
430+
squeezer.tooltip_delay = 1500
429431
return squeezer
430432

431433
@patch('idlelib.squeezer.Hovertip', autospec=Hovertip)
432434
def test_init_no_tooltip(self, MockHovertip):
433435
"""Test the simplest creation of an ExpandingButton"""
434436
squeezer = self.make_mock_squeezer()
435-
squeezer.get_show_tooltip.return_value = False
437+
squeezer.should_show_tooltip = False
436438
text_widget = squeezer.editwin.text
437439

438440
expandingbutton = ExpandingButton('TEXT', 'TAGS', 30, squeezer)
@@ -457,8 +459,8 @@ def test_init_no_tooltip(self, MockHovertip):
457459
def test_init_tooltip(self, MockHovertip):
458460
"""test tooltip creation"""
459461
squeezer = self.make_mock_squeezer()
460-
squeezer.get_show_tooltip.return_value = True
461-
squeezer.get_tooltip_delay.return_value = SENTINEL_VALUE
462+
squeezer.should_show_tooltip = True
463+
squeezer.tooltip_delay = SENTINEL_VALUE
462464
expandingbutton = ExpandingButton('TEXT', 'TAGS', 30, squeezer)
463465

464466
# check that ToolTip was called once, with appropriate values
@@ -534,7 +536,7 @@ def test_preview(self):
534536
expandingbutton = ExpandingButton('TEXT', 'TAGS', 30, squeezer)
535537
expandingbutton.selection_own = Mock()
536538

537-
with patch('idlelib.textview.view_text', autospec=view_text)\
539+
with patch('idlelib.squeezer.view_text', autospec=view_text)\
538540
as mock_view_text:
539541
# trigger the preview event
540542
expandingbutton.preview(event=Mock())

0 commit comments

Comments
 (0)
0