PySys_AuditTuple() args must be a tuple

vstinner · vstinner · commit 8f6f5661262b · 2023-09-19T18:59:19.000+02:00
diff --git a/Doc/c-api/sys.rst b/Doc/c-api/sys.rst
@@ -316,8 +316,8 @@ accessible to C code.  They all work with the current interpreter thread's
 
 .. c:function:: int PySys_AuditTuple(const char *event, PyObject *args)
 
-   Similar to :c:func:`PySys_Audit`, but pass arguments as a Python object. To
-   pass no arguments, *args* can be *NULL*.
+   Similar to :c:func:`PySys_Audit`, but pass arguments as a Python object.
+   *args* must be a :class:`tuple`. To pass no arguments, *args* can be *NULL*.
 
    .. versionadded:: 3.13
 
diff --git a/Programs/_testembed.c b/Programs/_testembed.c
@@ -1345,9 +1345,9 @@ static int test_audit_tuple(void)
     if (int_arg == NULL) {
         goto error;
     }
-    assert(PySys_AuditTuple("_testembed.set", int_arg) == 0);
-    assert(!PyErr_Occurred());
-    assert(sawSet == 555);
+    assert(PySys_AuditTuple("_testembed.set", int_arg) == -1);
+    assert(PyErr_ExceptionMatches(PyExc_TypeError));
+    PyErr_Clear();
     Py_DECREF(int_arg);
 
     // NULL is accepted and means "no arguments"
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -354,6 +354,12 @@ int
 PySys_AuditTuple(const char *event, PyObject *args)
 {
     if (args) {
+        if (!PyTuple_Check(args)) {
+            PyErr_Format(PyExc_TypeError, "args must be tuple, got %s",
+                         Py_TYPE(args)->tp_name);
+            return -1;
+        }
+
         return PySys_Audit(event, "O", args);
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -354,6 +354,12 @@ int`
`354`	`354`	`PySys_AuditTuple(const char event, PyObject args)`
`355`	`355`	`{`
`356`	`356`	`if (args) {`
	`357`	`+ if (!PyTuple_Check(args)) {`
	`358`	`+ PyErr_Format(PyExc_TypeError, "args must be tuple, got %s",`
	`359`	`+ Py_TYPE(args)->tp_name);`
	`360`	`+ return -1;`
	`361`	`+ }`
	`362`	`+`
`357`	`363`	`return PySys_Audit(event, "O", args);`
`358`	`364`	`}`
`359`	`365`	`else {`